Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Redesign #22

Merged
merged 2 commits into from
Jul 14, 2020
Merged

UI Redesign #22

merged 2 commits into from
Jul 14, 2020

Conversation

pietroglyph
Copy link
Member

  • Rearranges the UI into a more rigidly gridded system that can display multiple cameras and tabs at once.
  • Everything is responsive and works at a variety of screen sizes.
  • Refactors many parts of the Vue code (e.g. theming) to be more maintainable.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #22 into master will increase coverage by 0.06%.
The diff coverage is 84.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #22      +/-   ##
============================================
+ Coverage     53.03%   53.10%   +0.06%     
- Complexity      483      488       +5     
============================================
  Files           140      140              
  Lines          3986     4009      +23     
  Branches        364      367       +3     
============================================
+ Hits           2114     2129      +15     
- Misses         1755     1762       +7     
- Partials        117      118       +1     
Impacted Files Coverage Δ Complexity Δ
...sion/common/configuration/PhotonConfiguration.java 44.44% <ø> (ø) 6.00 <0.00> (ø)
...rg/photonvision/vision/processes/VisionModule.java 36.00% <57.89%> (-1.33%) 13.00 <2.00> (ø)
...ision/vision/frame/consumer/MJPGFrameConsumer.java 57.14% <100.00%> (ø) 6.00 <3.00> (+1.00)
...otonvision/vision/pipeline/ReflectivePipeline.java 97.47% <100.00%> (+0.23%) 5.00 <0.00> (+1.00)
...ision/vision/pipeline/result/CVPipelineResult.java 100.00% <100.00%> (ø) 10.00 <3.00> (+3.00)
.../org/photonvision/vision/target/TrackedTarget.java 75.36% <100.00%> (+0.36%) 18.00 <1.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aed92e7...59630a0. Read the comment docs.

@pietroglyph
Copy link
Member Author

pietroglyph commented Jul 9, 2020

There are two approaches to get this merged:

  1. Do some usability testing vs. the old UI and see which users like better. Use this testing to see if we merge this PR or keep the old UI.
  2. Decide that we want to use the new UI. Merge this PR and then do usability testing and make more PRs to address concerns brought up during usability testing.

@Bankst
Copy link
Member

Bankst commented Jul 12, 2020

@pietroglyph pietroglyph force-pushed the ui-refresh branch 2 times, most recently from 4961165 to 51ec91b Compare July 14, 2020 02:00
@pietroglyph pietroglyph requested a review from a team as a code owner July 14, 2020 02:00
@mcm001 mcm001 merged commit 8b46ad1 into PhotonVision:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants