Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build-push-action condition #790

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Fix build-push-action condition #790

merged 6 commits into from
Jul 9, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jul 9, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Two steps of the Docker build (building and pushing and latest to DH) should be skipped if the push-to-dockerhub value is false, and the condition is broken (always skip).

Description of the Change:
Fix the condition.

Benefits:

Possible Drawbacks:

Related GitHub Issues:
[sc-68127]

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.88%. Comparing base (a5c349c) to head (933e488).
Report is 93 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a5c349c) and HEAD (933e488). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (a5c349c) HEAD (933e488)
6 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #790       +/-   ##
===========================================
- Coverage   94.37%   27.88%   -66.49%     
===========================================
  Files         115       17       -98     
  Lines       17638     1886    -15752     
===========================================
- Hits        16645      526    -16119     
- Misses        993     1360      +367     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review July 9, 2024 15:39
@vincentmr vincentmr requested a review from a team July 9, 2024 15:39
@AmintorDusko AmintorDusko requested a review from a team July 9, 2024 16:08
@vincentmr vincentmr merged commit be07bbe into master Jul 9, 2024
51 of 52 checks passed
@vincentmr vincentmr deleted the docker_if_push branch July 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants