Skip to content

Commit be07bbe

Browse files
Fix build-push-action condition (#790)
### Before submitting Please complete the following checklist when submitting a PR: - [x] All new features must include a unit test. If you've fixed a bug or added code that should be tested, add a test to the [`tests`](../tests) directory! - [x] All new functions and code must be clearly commented and documented. If you do make documentation changes, make sure that the docs build and render correctly by running `make docs`. - [x] Ensure that the test suite passes, by running `make test`. - [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing the change, and including a link back to the PR. - [x] Ensure that code is properly formatted by running `make format`. When all the above are checked, delete everything above the dashed line and fill in the pull request template. ------------------------------------------------------------------------------------------------------------ **Context:** Two steps of the Docker build (building and pushing <version> and `latest` to DH) should be skipped if the `push-to-dockerhub` value is `false`, and the condition is broken (always skip). **Description of the Change:** Fix the condition. **Benefits:** **Possible Drawbacks:** **Related GitHub Issues:** --------- Co-authored-by: ringo-but-quantum <[email protected]>
1 parent a5c349c commit be07bbe

File tree

3 files changed

+7
-16
lines changed

3 files changed

+7
-16
lines changed

.github/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,17 @@
88
[(#788)](https://github.com/PennyLaneAI/pennylane-lightning/pull/788)
99

1010
### Improvements
11+
1112
* Add a Catalyst-specific wrapping class for Lightning Kokkos.
1213
[(#770)](https://github.com/PennyLaneAI/pennylane-lightning/pull/770)
1314

1415
### Documentation
1516

1617
### Bug fixes
1718

19+
* Fix conditions for skipping build & push steps in the Docker build workflows.
20+
[(#790)](https://github.com/PennyLaneAI/pennylane-lightning/pull/790)
21+
1822
* Downgrade Scipy on Lightning stable version tests.
1923
[(#783)](https://github.com/PennyLaneAI/pennylane-lightning/pull/783)
2024

.github/workflows/docker_linux_x86_64.yml

+2-15
Original file line numberDiff line numberDiff line change
@@ -81,25 +81,12 @@ jobs:
8181
8282
- name: Build and push version
8383
uses: docker/build-push-action@v5
84-
if: ${{ inputs.push-to-dockerhub == 'true' }}
84+
if: ${{ inputs.push-to-dockerhub }}
8585
with:
8686
push: ${{ inputs.push-to-dockerhub }}
8787
context: .
8888
file: docker/Dockerfile
89-
tags: pennylaneai/pennylane:${{ inputs.lightning-version }}-${{ matrix.pl_backend }}
90-
target: wheel-${{ matrix.pl_backend }}
91-
build-args: |
92-
LIGHTNING_VERSION=${{ inputs.lightning-version }}
93-
PENNYLANE_VERSION=${{ inputs.pennylane-version }}
94-
95-
- name: Build and push latest
96-
uses: docker/build-push-action@v5
97-
if: ${{ inputs.push-to-dockerhub == 'true' }}
98-
with:
99-
push: ${{ inputs.push-to-dockerhub }}
100-
context: .
101-
file: docker/Dockerfile
102-
tags: pennylaneai/pennylane:latest-${{ matrix.pl_backend }}
89+
tags: pennylaneai/pennylane:${{ inputs.lightning-version }}-${{ matrix.pl_backend }},pennylaneai/pennylane:latest-${{ matrix.pl_backend }}
10390
target: wheel-${{ matrix.pl_backend }}
10491
build-args: |
10592
LIGHTNING_VERSION=${{ inputs.lightning-version }}

pennylane_lightning/core/_version.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,4 +16,4 @@
1616
Version number (major.minor.patch[-label])
1717
"""
1818

19-
__version__ = "0.38.0-dev3"
19+
__version__ = "0.38.0-dev4"

0 commit comments

Comments
 (0)