Put back Python_EXECUTABLE in setup.py. #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
mlxd
reviewed
Jun 21, 2023
|
Should we update the changelog for this? |
Yep :) |
Codecov Report
@@ Coverage Diff @@
## master #461 +/- ##
=======================================
Coverage 99.82% 99.82%
=======================================
Files 50 50
Lines 4667 4667
=======================================
Hits 4659 4659
Misses 8 8
|
AmintorDusko
approved these changes
Jun 21, 2023
mlxd
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Thanks for the quick turnaround @vincentmr
Feel free to merge when CI is done.
vincentmr
added a commit
that referenced
this pull request
Jun 21, 2023
* Put back Python_EXECUTABLE in setup.py. * Auto update version * Trigger CI * Fix PYTHON_EXECUTABLE case. * Fix PYTHON_EXECUTABLE case MacOS. * Update changelog [skip ci]. * Trigger CI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com>
mlxd
added a commit
that referenced
this pull request
Jun 26, 2023
* Initial commit for Lightning v0.31.0_rc * Update changelog. * Bump pennylane_requires to 0.30. * Add git safe dir override for Kokkos docker builds (#452) * Add git safe dir override for Kokkos docker builds * Auto update version * Update changelog --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> * Specify PYTHON_EXECUTABLE in CMAKE_ARGS. * Fix case of Python_EXECUTABLE CMAKE var. * Put back Python_EXECUTABLE in setup.py. (#461) * Put back Python_EXECUTABLE in setup.py. * Auto update version * Trigger CI * Fix PYTHON_EXECUTABLE case. * Fix PYTHON_EXECUTABLE case MacOS. * Update changelog [skip ci]. * Trigger CI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> * Build against PL-rc branch. * --force-reinstall autograd numpy==1.23.5 * Revert changes. * Update changelog. * Revert changes made on wrong branch. * Trigger CI * Auto update version * Revert RC test branches to master --------- Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
The last dev release of Lightning has broken wheels. The incorrect Python version is found by CMake and hence all modules are built against Python 3.6, rather than the required version.
Description of the Change:
Specify version number from
sysinsetup.py.Benefits:
Fixes wheels.
Possible Drawbacks:
Related GitHub Issues: