Add git safe dir override for Kokkos docker builds #452
Conversation
Codecov Report
@@ Coverage Diff @@
## v0.31.0_rc #452 +/- ##
==============================================
+ Coverage 92.07% 99.82% +7.75%
==============================================
Files 50 50
Lines 4667 4667
==============================================
+ Hits 4297 4659 +362
+ Misses 370 8 -362
|
There was a problem hiding this comment.
Hi @mlxd, do you happen to have any insight on what might have caused this error message to appear?
Without explicitly going through the history of invalidated Kokkos caches and the associated Docker images used in the builds, I cannot tell. Though, I suspect it is due to a change in either git versions, or how docker handles permissions across mounts. |
There was a problem hiding this comment.
Hi @mlxd, do you happen to have any insight on what might have caused this error message to appear?
Without explicitly going through the history of invalidated Kokkos caches and the associated Docker images used in the builds, I cannot tell. Though, I suspect it is due to a change in either git versions, or how docker handles permissions across mounts.
That makes sense. We are good to go!
* Initial commit for Lightning v0.31.0_rc * Update changelog. * Bump pennylane_requires to 0.30. * Add git safe dir override for Kokkos docker builds (#452) * Add git safe dir override for Kokkos docker builds * Auto update version * Update changelog --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> * Specify PYTHON_EXECUTABLE in CMAKE_ARGS. * Fix case of Python_EXECUTABLE CMAKE var. * Put back Python_EXECUTABLE in setup.py. (#461) * Put back Python_EXECUTABLE in setup.py. * Auto update version * Trigger CI * Fix PYTHON_EXECUTABLE case. * Fix PYTHON_EXECUTABLE case MacOS. * Update changelog [skip ci]. * Trigger CI --------- Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> * Build against PL-rc branch. * --force-reinstall autograd numpy==1.23.5 * Revert changes. * Update changelog. * Revert changes made on wrong branch. * Trigger CI * Auto update version * Revert RC test branches to master --------- Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Dev version update bot <github-actions[bot]@users.noreply.github.com> Co-authored-by: Vincent Michaud-Rioux <[email protected]> Co-authored-by: Amintor Dusko <[email protected]>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: To avoid issues around git directory safety and ownership as seen in https://github.com/PennyLaneAI/pennylane-lightning/actions/runs/5058417626/jobs/9078527537#step:6:153 we must explicitly mark the mounted /io directory as safe to ensure cross-platforms builds continue to work.
Description of the Change: Marked
/iodirectory as safe for docker-enabled cross-platform builds on arm and powerpc.Benefits: Ensure aarch64 and ppc64le wheels will successfully continue to build on release.
Possible Drawbacks:
Related GitHub Issues: