Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for Python 3.6 and adds support for Python 3.9 #128

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

trbromley
Copy link
Contributor

@trbromley trbromley commented Aug 11, 2021

The deploy workflow is already set up for 3.7 - 3.9, so hopefully on the next release we'll have the 3.9 binaries!

Closes #96
Closes #116

@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
164 tests ±0  164 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
694 runs  ±0  694 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e5c980e. ± Comparison against base commit e5c980e.

♻️ This comment has been updated with latest results.

@codecov
Copy link

codecov bot commented Aug 11, 2021

Codecov Report

Merging #128 (612e0b2) into master (e443bcf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #128   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           56        56           
=========================================
  Hits            56        56           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e443bcf...612e0b2. Read the comment docs.

Comment on lines -211 to 214
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3 :: Only",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trbromley would it be good to reflect this already in the v0.17.0 release? Will v0.17.0 discontinue support for Python 3.6/add support for Python 3.9?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antalszava yes this would be good to merge into the release branch too - I think we should drop 3.6 support in this release since it's not anyway currently supported in current PL.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great! @albi3ro could you maybe delete the "Programming Language :: Python :: 3.6", line from setup.py in #127?

@trbromley trbromley requested a review from mlxd August 11, 2021 14:50
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@trbromley trbromley merged commit e5c980e into master Aug 13, 2021
@trbromley trbromley deleted the remove_3.6 branch August 13, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Python version support Support Python 3.9
3 participants