Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V17.0 increment version #127

Merged
merged 10 commits into from
Aug 11, 2021
Merged

V17.0 increment version #127

merged 10 commits into from
Aug 11, 2021

Conversation

albi3ro
Copy link
Contributor

@albi3ro albi3ro commented Aug 10, 2021

This PR increments the version variable, updates the changelog, adds a gitignore entry to a build artifacts folder, and corrects the test building command on the readme.

mlxd and others added 3 commits August 10, 2021 13:51
* Add utility to get qubit number

* Define gate overloads to enable run-time generalised calls

* Update method signatures

* Update changelog
* Fix column major data layout bindings

* Update changelog
@albi3ro albi3ro requested a review from antalszava August 10, 2021 16:05
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #127 (b91502d) into v0.17.0-rc0 (800eaf3) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b91502d differs from pull request most recent head e2f0eda. Consider uploading reports for the commit e2f0eda to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           v0.17.0-rc0      #127   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files                3         3           
  Lines               54        54           
=============================================
  Hits                54        54           
Impacted Files Coverage Δ
pennylane_lightning/_version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 800eaf3...e2f0eda. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2021

Test Report (C++) on Ubuntu

    1 files  ±0      1 suites  ±0   0s ⏱️ ±0s
164 tests ±0  164 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
694 runs  ±0  694 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit e2f0eda. ± Comparison against base commit 800eaf3.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@trbromley trbromley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Why are we including abf7b99 and 14ea923 which have happened post feature freeze? 14ea923 is a bug fix so that's fine, but abf7b99 is a new feature and probably skippable (if we're adhering strictly to feature freeze).

Copy link
Contributor

@antalszava antalszava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉 Maybe indeed worth leaving the post-feature freeze commits out, as Tom pointed out. That just helps with reflecting the state of the release candidate.

@antalszava
Copy link
Contributor

[ch7894]

@@ -16,4 +16,4 @@
Version number (major.minor.patch[-label])
"""

__version__ = "0.16.0-dev"
__version__ = "0.17.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update the version of PL that lightning depends on? Currently we have >=0.15 in requirements.txt and lightning_qubit.py. It might still work with 0.15, but probably best to go with 0.17?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'd usually do that if there's a feature that lightning depends on after v0.15.0. That is: we'd pin to the latest released version of PennyLane that the plugin is still fully functional with.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and should be ok in this case! Though maybe this is something we should test in the long run, I don't trust my own memory on whether subsequent changes should break compatibility with older versions of PL.

@antalszava antalszava merged commit 9375927 into v0.17.0-rc0 Aug 11, 2021
@antalszava antalszava deleted the v17.0-increment-version branch August 11, 2021 20:34
antalszava added a commit that referenced this pull request Aug 17, 2021
* V17.0 increment version (#127)

* Update method signatures for bound class (#125)

* Add utility to get qubit number

* Define gate overloads to enable run-time generalised calls

* Update method signatures

* Update changelog

* Fix column major data layout in bindings (#126)

* Fix column major data layout bindings

* Update changelog

* increment version, update changelog, gitignore a build folder

* no Python version 3.6

* changelog for removing Python 3.6

* Revert "Fix column major data layout in bindings (#126)"

This reverts commit 14ea923.

* resolve changelog conflict

* Update .github/CHANGELOG.md

* Revert "Revert "Fix column major data layout in bindings (#126)""

This reverts commit 1de97e6.

Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Antal Szava <[email protected]>

* organise changelog

* version bump

Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Lee James O'Riordan <[email protected]>
mlxd added a commit that referenced this pull request Aug 20, 2021
* V17.0 increment version (#127)

* Update method signatures for bound class (#125)

* Add utility to get qubit number

* Define gate overloads to enable run-time generalised calls

* Update method signatures

* Update changelog

* Fix column major data layout in bindings (#126)

* Fix column major data layout bindings

* Update changelog

* increment version, update changelog, gitignore a build folder

* no Python version 3.6

* changelog for removing Python 3.6

* Revert "Fix column major data layout in bindings (#126)"

This reverts commit 14ea923.

* resolve changelog conflict

* Update .github/CHANGELOG.md

* Revert "Revert "Fix column major data layout in bindings (#126)""

This reverts commit 1de97e6.

Co-authored-by: Lee James O'Riordan <[email protected]>
Co-authored-by: Antal Szava <[email protected]>

* Update documentation for Python bindings

* Add docstrings to gate matrix definitions

* Add docstrings for all publically facing statevector methods

* Fix incorrectly labelled gatecalls

* Update doxygen comments to ignore anon namespaces

* Move exc into namespace

* Update missing gates

* Enable build of C++ API with docs

* Add C++ API to docs

* Add C4 arch diagrams for lightning

* Add sample C4 architecture for lightning using current design

* Fix missing packages

* Update documentation architecture

* Prevent bindings from generating API docs

* Update changelog

Co-authored-by: Christina Lee <[email protected]>
Co-authored-by: Antal Szava <[email protected]>
Co-authored-by: Tom Bromley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants