-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V17.0 increment version #127
Conversation
* Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog
* Fix column major data layout bindings * Update changelog
Codecov Report
@@ Coverage Diff @@
## v0.17.0-rc0 #127 +/- ##
=============================================
Coverage 100.00% 100.00%
=============================================
Files 3 3
Lines 54 54
=============================================
Hits 54 54
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉 Maybe indeed worth leaving the post-feature freeze commits out, as Tom pointed out. That just helps with reflecting the state of the release candidate.
[ch7894] |
@@ -16,4 +16,4 @@ | |||
Version number (major.minor.patch[-label]) | |||
""" | |||
|
|||
__version__ = "0.16.0-dev" | |||
__version__ = "0.17.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also need to update the version of PL that lightning depends on? Currently we have >=0.15
in requirements.txt
and lightning_qubit.py
. It might still work with 0.15, but probably best to go with 0.17?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'd usually do that if there's a feature that lightning depends on after v0.15.0. That is: we'd pin to the latest released version of PennyLane that the plugin is still fully functional with.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense and should be ok in this case! Though maybe this is something we should test in the long run, I don't trust my own memory on whether subsequent changes should break compatibility with older versions of PL.
This reverts commit 1de97e6.
…ylane-lightning into v17.0-increment-version
* V17.0 increment version (#127) * Update method signatures for bound class (#125) * Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog * Fix column major data layout in bindings (#126) * Fix column major data layout bindings * Update changelog * increment version, update changelog, gitignore a build folder * no Python version 3.6 * changelog for removing Python 3.6 * Revert "Fix column major data layout in bindings (#126)" This reverts commit 14ea923. * resolve changelog conflict * Update .github/CHANGELOG.md * Revert "Revert "Fix column major data layout in bindings (#126)"" This reverts commit 1de97e6. Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Antal Szava <[email protected]> * organise changelog * version bump Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Lee James O'Riordan <[email protected]>
* V17.0 increment version (#127) * Update method signatures for bound class (#125) * Add utility to get qubit number * Define gate overloads to enable run-time generalised calls * Update method signatures * Update changelog * Fix column major data layout in bindings (#126) * Fix column major data layout bindings * Update changelog * increment version, update changelog, gitignore a build folder * no Python version 3.6 * changelog for removing Python 3.6 * Revert "Fix column major data layout in bindings (#126)" This reverts commit 14ea923. * resolve changelog conflict * Update .github/CHANGELOG.md * Revert "Revert "Fix column major data layout in bindings (#126)"" This reverts commit 1de97e6. Co-authored-by: Lee James O'Riordan <[email protected]> Co-authored-by: Antal Szava <[email protected]> * Update documentation for Python bindings * Add docstrings to gate matrix definitions * Add docstrings for all publically facing statevector methods * Fix incorrectly labelled gatecalls * Update doxygen comments to ignore anon namespaces * Move exc into namespace * Update missing gates * Enable build of C++ API with docs * Add C++ API to docs * Add C4 arch diagrams for lightning * Add sample C4 architecture for lightning using current design * Fix missing packages * Update documentation architecture * Prevent bindings from generating API docs * Update changelog Co-authored-by: Christina Lee <[email protected]> Co-authored-by: Antal Szava <[email protected]> Co-authored-by: Tom Bromley <[email protected]>
This PR increments the version variable, updates the changelog, adds a gitignore entry to a build artifacts folder, and corrects the test building command on the readme.