Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset ascendancy class before changing base class again #7024

Merged

Conversation

Lilylicious
Copy link
Contributor

@Lilylicious Lilylicious commented Dec 13, 2023

Fixes #6963

Description of the problem being solved:

In the changes made to support secondary ascendancy classes, the code to reset the current ascendancy class when changing base class was changed to deallocate the old ascendancy instead of all ascendancies that isn't the new one. This didn't work because selectClass already changes the current class before calling selectAscendClass.

This change is pretty simple, it simply makes the reset a function that is called by both SelectClass and SelectAscendClass. This does mean we're running it unnecessarily in SelectAscendClass when called from SelectClass, but this way avoids breaking any of the other uses so I felt like this was a fair compromise.

Steps taken to verify a working solution:

  • Swapped between various ascendancies. The bug doesn't seem to always appear, but swapping between ascendant and other classes always seems to cause the issue.

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Dec 13, 2023
@LocalIdentity LocalIdentity merged commit b349663 into PathOfBuildingCommunity:dev Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switching classes does not reset primary ascendency passives
2 participants