add Colorblind tree search highlight support #6866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
LocalIdentity
requested changes
Nov 13, 2023
|
Hi, I add screenshots of config tab in options and remove VS config from Launch.lua |
LocalIdentity
approved these changes
Nov 27, 2023
LocalIdentity
approved these changes
Dec 1, 2023
| end | ||
| end | ||
|
|
||
| function hexToRGB(hex) | ||
| hex = hex:gsub("0x", "") -- Remove "0x" prefix |
There was a problem hiding this comment.
Thanks for adding comments on what the regex sub is meant to do
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description of the problem being solved:
This PR solve the isssue "Colorblind tree search highlight support". The functionality was done according to PR #6070.
Steps taken to verify a working solution:
-create edit and tooltip labels for user input
-create function inside of labels which check hex code and then execute function updateColor
-update function updateColor from which I trigger own created function which convert Hex color code to RGB
-save RGB code to array and change parameters for drawing color function in PassiveTreeView.lua
Link to a build that showcases this PR:
Before screenshot:
After screenshot: