Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorblind tree search highlight support #6253

Closed
1 task done
po0p opened this issue May 31, 2023 · 6 comments
Closed
1 task done

Colorblind tree search highlight support #6253

po0p opened this issue May 31, 2023 · 6 comments
Assignees
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers

Comments

@po0p
Copy link

po0p commented May 31, 2023

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Now that there is some support for node POWER colours and custom colours for positive/negative values in the tooltip, the search of the nodes is still RED highlight on dark (default tree bg) background. Which I personally really can not see at instant, so to find a node in the tree using search I have to rescan whole tree with my eyes to try to catch that red circle. I am sure people with same colourblindness problem would confirm (not the green-red guys, more like dark red / dark green guys) the same problem :)

Describe the solution you'd like

Add a similar setting for highlighting searched nodes on the tree as it is now for "Node Power colours" (so a predefined green/blue colour) or a Hex colour setting.
Hex colour would be best, because that would allow people with different vision problems to choose the right colour for themselves. As for me personally - best would be bright yellow, or something that otherwise stands out of dark background of tree/nodes A LOT. But that may not be the case for other people.

Describe alternatives you've considered

getting a new pair of eyes

Additional context

No response

@po0p po0p added the enhancement New feature, calculation, or mod label May 31, 2023
@po0p
Copy link
Author

po0p commented May 31, 2023

1080p example
image

@Peechey
Copy link
Contributor

Peechey commented May 31, 2023

One easy solution would be to reuse the negative hex colour option.

image

@QuickStick123 QuickStick123 added the good first issue Good for newcomers label Aug 14, 2023
@admSla
Copy link
Contributor

admSla commented Oct 8, 2023

Hi, is this issue junior developer friendly ? Im just looking for my first open source issue and I use Path of Building frequently. If this issue is free can you say me more details and asign the issue ? Thanks.

@LocalIdentity
Copy link
Contributor

@AdamSlaninka i think it should be fairly straightforward to add. Heres the PR that added the other hex change values #6070
Message me on discord (localidentity) and I can give you an inv to the PoB discord if you have any further questions

@admSla
Copy link
Contributor

admSla commented Nov 13, 2023

Hi, I open PR #6866

@Peechey
Copy link
Contributor

Peechey commented Jan 5, 2024

PR #6866 was merged

@Peechey Peechey closed this as completed Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants