Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only add abyssal socket if the item is an energy blade #6550

Merged

Conversation

Lilylicious
Copy link
Contributor

Fixes a bug that was introduced in #6446 where it would duplicate the abyssal socket explicit modifiers on imported items that weren't energy blades. Specifically, Stygian Vise in general and Darkness Enthroned were affected by this.

Description of the problem being solved:

Checked with Wires, the insert of the mod was only intended for energy blades, so adding a conditional for that.

Steps taken to verify a working solution:

  • Checked imports with both Stygian Vises and Energy Blades with abyssal sockets, both work as expected

Link to a build that showcases this PR:

Import Strong_and_intelligent from Xeverous (Ancestor League), or BeethovensRagingSpirit from Lordofdiamonds (EOE Moana league)

@LocalIdentity LocalIdentity added the bug: behaviour Behavioral differences label Sep 5, 2023
@LocalIdentity LocalIdentity merged commit 487951a into PathOfBuildingCommunity:dev Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants