Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework the way Triggers are calculated #6468

Merged
merged 38 commits into from
Aug 24, 2023
Merged

Rework the way Triggers are calculated #6468

merged 38 commits into from
Aug 24, 2023

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Aug 24, 2023 •
edited by LocalIdentity
Loading

--- Implemented Enhancements ---

  • Support for triggered skills has been reworked.
    • Calculations of effective triggered skills trigger rate should now be more accurate.
    • Improve cooldown breakpoint interactions with skills that add cast time.
    • Implemented all currently existing trigger skills that POB is capable of supporting. Including:
      • CWDT
      • Spell Slinger
      • Counter attack skills
      • Arcanist brand
      • Tawhoa's Chosen
      • Battlemage's Cry
  • Implemented Trigger Bots.

--- User Interface ---

  • Trigger related breakdowns should now be more descriptive.
  • Improve breakdowns for skills that add cast time.
  • Display Cast When damage taken threshold in the trigger rate section

--- Fixed Bugs ---

  • Triggers should now correctly account for source rate modifiers such as crit chance and accuracy.
  • Fixed inaccuracies caused by incorrect handling of skill cooldown during skill rotation simulation.
  • Fixed a crash caused by an interaction between unleash and nested triggers.
  • Fixed many self triggers counting as self cast.
  • Fixed incorrect handling of gems supported by more than one trigger.

github-actions bot and others added 30 commits May 26, 2023 00:10
@github-actions
Weekly beta release
4b7aa93
@Paliak @Wires77
Seperate skill cooldown from trigger cooldown and fix multiple relate…
20d2a3b 
…d issues. (PathOfBuildingCommunity#4599)

* FIX: Change the Kitava's Thirst trigger mod description to one that is used in game and add parsing for it.

* FIX/FEAT: Correct trigger calculations for Kitava's thirst and Craft trigger. Improve handling of skill cooldown overrride. Add handing for multipler triggers supporting one skill

* FIX: Readd a commit lost during rebase that fixes cooldown override.

* FIX: Handling of Focus triggers. Triggers assume perfect focus reuse as self casting the focus skill is the only way to obtain focus currently.

* FIX: Fix cooldown recovery not applying when using cooldownoverride.

* FIX: Fix crashing due to incorrect handling of minion trigger rate calculations.

* FIX: Correct calculations for cwdt. Account for possible issues resulting from skillData.cooldown working differently.

* FIX: Correct potentially wrong values for "SummonRigwaldsPack"

* FEAT: Improve source skill selection for Craft trigger

* FIX: Fixing typos and formatting

* FIX: Specific handling for Cast When Damage Taken

* FIX: Fix max duration not being displayed properly for cwdt

* FIX: Handle Cast on Melee kill

* FEAT: Add basic support for global triggers

* FEAT: Add basic support for spellslinger

* FEAT: Add support for Mark on hit

* FIX: Improve trigger source selection requirements for a variety of trigger skills

* FEAT: Add basic handling for counter attack skills with internal triggers

* FEAT: Add breakdown for arcanist brand casts per second calcualtion. Simplify arcanist brand related math. Remove redundant s_format calls

* FEAT: Some minor refactoring

* FEAT: Refactoring and add support for more unique triggers

* FIX: Change skill stat for cwdt

* FIX/FEAT: Add support for more uniques and hextouch. Minor refactoring. Fix crash when uniqueTriggerName is nil.

* FEAT: Add support for Tawhoa's_Chosen

* FIX: minor cleanup

* FEAT/FIX: Small improvements to error messages and breakdowns. Fix edge cases with in Tawhoa's Chosen implementation that caused crashes.

* FEAT/FIX: Implement Replica Maloney's mechanism. Add extra checks for minion trigger source selection.

* FIX: Cleanup and refactoring

* FIX: Restrict Tawhoa's Chosen to attack slams not just any slams

* FIX: fix trigger source location finding not working for global triggers

* FEAT: Add parsing for chance to trigger. Minor cleanup. Skill re export.

* FIX: fix multistrike crash caused by bad export

* FIX/FEAT: Add recently merged to dev handling for a new flag. Fix some uniques not working due to last skills export.

* FEAT: Improve breakdowns when SpellCastTimeAddedToCooldownIfTriggered is set

* FEAT: More improvements to breakdowns

* FIX: if cast time is added to trigger cooldown it should account for cast time modifiers

* FIX: disable  unseen strike when not phasing

* FEAT: Add proper support for CWC and make it work with lightning conduit

* FIX/FEAT: Add better support for addsCastTime to other triggers. Minor cleanup

* FIX: more consistent variable names.

* FIX: minor cleanup

* FIX: fix crash fix arakali's fang using old var

* FIX: fix unleash trigger source handling

* FIX: remove some redundant code.

* FIX: arcanist brand used cooldown for speed.

* FIX: arcanist brand breakdown

* FIX: Apply QuickStick's arcanist brand formula.

* FIX: handling of arcanist brand

Now should correctly calculate the impact of multiple linked skills

* FIX: minor breakdown formatting fix

* FIX: stop tawoah's chosen from using totems

* FIX: Use the modlist of the actual brand gem.

Arcanist brand has a hidden support gem that supports linked gems and
causes them to trigger but most the of important stats are in the mod
list of the actual main gem os use that instead.

* FIX: better support TriggerDamage mod.

Should properly handle TriggerDamage mods such as the ones on arcanist
brand. Also fixed arcanist brand config option requiring hit flag.

* FIX: trigger damage mods not working for cwc

* FIX: fix missing trigger name for holy relic

* WIP: major renaming.Changed order of operations.

* WIP: more work on reordering application of mods

* WIP: Minor fixes for self triggers

* WIP: fixes to Tawhoa's Chosen

* FIX: prevent the saviour from using totem skills

* FIX: icdr not being considered for alignment

* FIX: update Cwc/Focus to new format

* FIX: misspelled word

* FIX: fix kitava's thirst calcs

* FIX: add src rate is effective switch

Used for Atziri's rule

* FIX: breakdown ordering issue

* FIX: remove dead code

* FIX: self trigger calcs

* FIX: hextouch support

* FIX: minor fixes to unique various triggers

* FIX: spelling issues

* FIX: arcanist brand improvements

* WIP: implement faster skill rotation simulator

Based on:
PathOfBuildingCommunity#5428

* WIP: remove unnecessary for loop

* FIX: lower sim resolution, implement ceil func with base

* FIX: fix Tawhoa's Chosen

* FIX: off by one error due to different indexing

* FIX: fixed to new simulator

* FIX: minor formatting. Comments.

* FIX: remove helper func. Minor tweaks.

* FIX: spelling issues.

* FIX: change func name.Awaiting Dict update.

* FIX: adapt Cwc to work with new simulation.

* FIX: breakdown clarity. icdr fixes.

* FIX: use ceil_b and floor_b.

* FIX: crash due to no socketGroup

* FIX: hexes applied with hextouch have no mana cost

* FIX: hextouch should have no cost

* FIX: code formatting

* FEAT: implement vixens trigger.Minor fixes

* FIX:no sim for self triggers.Smarter breakdowns

* WIP: implement Impending doom.

Based on PathOfBuildingCommunity#5530

* FIX: fixes to impeding doom breakdown

* FIX: Tawhoa's Chosen simulation arguments

* FIX: triggered minion skills not using icdr.

If minions skills such as summon skeletons were triggered they would not
use player icdr mods due to using the wrong actor.

Additionally renamed some variables.

* WIP: initial work on CWDT loops support

* FIX: spelling

* FIX: global trigger not working as sources.

Use actor variable more often to improve minion skill support

* FIX: cd overrides should override trigger cd too.

* FIX: ignore dualwield impact if source is global

* FIX: limiting scope to self damage only.

CWDT loops while a really cool feature are hard to support correctly in
POB. Due the amount of assumptions the involved code has to make
regarding the state of the loop, the numbers aren't always accurate.
Staring with this commit the scope is being limited to only add support for
self hit damage as i think it'd be a waste to throw all that code away
and that part should work perfectly fine.

* FIX: arcanist brand being affected by tickrate

* FIX: uuid collision and remove confusing breakdown

* DOCS: add coomment.

* WIP: mixed group setups and two part skills fix

Currently there's an issue with two part skills (active and support)
such as Arcanist Brand where the support part will not be applied to
skills socketed into the same item but in different groups. An example
would be to two groups both socketed into Weapon 1. One having the
Arcane Brand skill gem and the other any other skill. The other skill
will not be supported by Arcane Surge even though they are socketed into
the same item and should be considered as linked.

* FIX: spelling

* FIX: add handling for shotgunning skills

* FIX: null skillpart and copy skill limit recursion

* FIX: hide trigger supports if not compatible

* FEAT: impl Battlemage's cry trigger

* FEAT: impl trigger rate for Combust

* FIX: skills from items not counting as sources

* FIX: remove unused flag

* FIX: unique triggers broken by wrong condition

* FEAT: basic support for skills with charges

* Add support for Prismatic Burst

* FEAT: hook up prismatic burst to trigger logic

* FIX: rename kitava's trigger and add threshold

* FEAT: comparer func + documenting comments

* FIX: spelling

* FEAT: hook up shockwave to trigger logic

* FIX: avoid scoping wierdness and remove debug log

* WIP: manaforged support

* FEAT: finish implementaion of manaforged

* FIX: red text on imepending doom

* FIX: merge issue

* FIX: minor issues with spellslinger

* FIX: mirager archer crash caused by merge

* FIX: small cleanup

* FIX:remove remenants of old handling for self trig

* FEAT: impl triggerbots

* FIX: better tooltip

* FIX: cleanup kitava's thirst cond

* FIX: spelling

* FIX: remove non trigger related changes

* WIP: inital work on moving trigger code

* WIP: fix arcanist brand crash

The defualt trigger handler still needs to be modified to work with the
new config format

* FIX: variety of new config compatibility issues

* FIX: trigger info issues

* FIX: variable names, refactoring

* FIX: missing variables

* FIX: mark mirage archer as a trigger

* FIX: missing actor variable

* FIX: CWC and added cast time breakdowns

* FIX: remove redundant limited processing check

* FIX: tweaks to Queen's Demand

* FIX: better feedback for COMK

* FIX: assumingEveryHitKills is not in config

* FIX: Awakened triggers not finding configs

* FIX: mark as not a triger when no config found

* FIX: ignoresTickRate being overwritten

* FIX: self trigger display name crash

* FIX/FEAT:impl vengance, use cap rate for self trig

* FIX: prevent battlemeage's cry self trigger

* FIX: hextouch shoulnd not be a global trigger

* FIX: misc fixes

---------

Co-authored-by: Wires77 <[email protected]>
@Paliak
FIX: cleanup Doom Blast implementation (PathOfBuildingCommunity#6296)
1b07e97
@Paliak
Add snipe to trigger rework (PathOfBuildingCommunity#6304)
3c7c3bc 
* Add proper support for DPS with Channeled skills that use stages

Channeling skills that used stages did not have their hit rate modified by the time it took to channel those stages
This PR adds `hitTimeMultiplier` values for Scourge Arrow, Divine Ire, Flameblast and Incinerate
Snipe is handled in it's own PR
This shows the channel time in the sidebar along with the correct hit rate for these skills
Adds boxes to the config page to set the number of nearby enemies for Divine Ire to calculate the correct charge rate

* Add support for triggered skills with Snipe Support

* Fix Snipe calcs for triggered skills and Assailum

* Fix breakdowns

* FEAT: impl snipe

* FIX: simplify triggered skills count logic

* FIX: use skill index from Snipe skill pool

* FIX: breakdown using triggeredName instead of triggerName

* FIX: remove unnecessary query for max stages

* FIX: merge conflict and improve breakdown

---------

Co-authored-by: LocalIdentity <[email protected]>
Merge branch 'dev' into beta
ebbe96d
Regen ModCache
9344d04
@Paliak
FIX: doubled code caused by merge (PathOfBuildingCommunity#6329)
3255abc
Merge branch 'dev' into beta
7ec3c75
Update Changelog with Beta changes
2ca5ac1
Beta Release 2.31.0
7171c6a 
BETA VERSION[2.31.0][2023/08/15]
--- Implemented Enhancements ---
* Support for triggered skills has been reworked.
    * Calculations of effective triggered skills trigger rate should now be more accurate.
    * Improve cooldown breakpoint interactions with skills that add cast time.
    * Implemented all currently existing trigger skills that POB is capable of supporting. Including:
        * CWDT
        * Spell Slinger
        * Counter attack skills
        * Arcanist brand
        * Tawhoa's Chosen
        * Battlemage's Cry
* Implemented Trigger Bots.

--- User Interface ---
* Trigger related breakdowns should now be more descriptive.
* Improve breakdowns for skills that add cast time.

--- Fixed Bugs ---
* Triggers should now correctly account for source rate modifiers such as crit chance and accuracy.
* Fixed inaccuracies caused by incorrect handling of skill cooldown during skill rotation simulation.
* Fixed a crash caused by an interation between unleash and nested triggers.
* Fixed many self triggers counting as self cast.
* Fixed incorrect handling of gems supported by more than one trigger.
Fix version number
873d051
@Paliak
FIX: triggeredSkills not being initialized (PathOfBuildingCommunity#6346
7dc7fb1 
)
Merge branch 'dev' into beta
24b9325
Release 2.31.1
0eb3553 
--- Fixed Crashes ---
* Fix Crash when using a weapon with a crafted Trigger mod
@Wires77
Update to version 2.31.2
bc0c635
@Wires77
Fix version number mishap
a60f77e
@Paliak @Wires77
Update mod wording and skill conds for Tawhoa's Chosen (PathOfBuildin…
d481f1a 
…gCommunity#6358)

* FIX: update mod wording and skill conds for tawhoa

* FIX: totem duration mods not applying

* No need for legacy mod

Signed-off-by: Wires77 <[email protected]>

---------

Signed-off-by: Wires77 <[email protected]>
Co-authored-by: Wires77 <[email protected]>
@Paliak
FEAT: display CWDT threshold (PathOfBuildingCommunity#6420)
7c615bb
@Paliak
FEAT: impl trigger rate cap override (PathOfBuildingCommunity#6404)
66c896b
@Paliak
(BETA) Fix secondary effect skills being added as supports (PathOfBui…
d17fb9e 
…ldingCommunity#6392)

* FIX:secondary effect skills being added as support

* FIX: preemptively fix merge issue
@Paliak @Wires77
@Regisle @LocalIdentity @Peechey @deathbeam @Lilylicious @Lancej @github-actions
Fixes merge issues caused by merging new changes into the trigger rew…
2581e60 
…ork code. (PathOfBuildingCommunity#6447)

* Fix version number mishap

* move timeless jewel stuff (PathOfBuildingCommunity#5747)

* move timeless jewel stuff

* add back all the local versions of functions for future use

* Help section improvements (PathOfBuildingCommunity#6156)

* increase size of box and text

* implement hotkey to directly open help at a given section

* add ability to "fast scroll" to next section

* add section heights to changelog

* update txt

* fix merge issue

* fix line overlap and add note about scrollbars

* Add lot of stuff for ancestor league (PathOfBuildingCommunity#6288)

* FEAT: impl explode and extra support mods

* FEAT: impl new aura recovery mod

* FEAT: impl between you and linked target mods

* FEAT: impl Sentinel of Radiance mod

Currently implemented as less damage taken as that's what the
spreadsheet said.

I think this may be possible to implement like frost shield or other
"taken before you" mods given more info on stats of the sentinel.

* FEAT: impl reserved mana as armor mod

* FIX: use arbitrary taken before you instead of generic less dmg taken

* FIX: cache result of dmg type max hit str concat

* FEAT: code for generally supporting have no mods

* FEAT: impl resistance conversion mods

* FEAT: impl extra jewel func code for new chief mod

* FEAT: impl mod on all other slots condition

* FEAT: add new uniques

* Wording fixes, new unique

* Remove debugging lines

* Adding fire mastery explosion mod

* FIX: use ailment immunity flags from PathOfBuildingCommunity#6297

* Late breaking Chieftain change

* Update mod ranges

* Fix Amulet and belt

---------

Co-authored-by: Wires77 <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>

* FEAT: add immunity flags to breakdown (PathOfBuildingCommunity#6389)

* FIX: fix totem duration mods not applying (PathOfBuildingCommunity#6388)

* Fix DPS on Vaal Flicker when using 2x 1h weapons (PathOfBuildingCommunity#6380)

The block was inside the 2 pass loop so was running twice
Also fixes the issue when you used a custom `more DPS` mod

Co-authored-by: LocalIdentity <[email protected]>

* Apply RepeatCount according to their SkillTypes (PathOfBuildingCommunity#6376)

* Apply RepeatCount according to their SkillTypes

* Fix Vaal Flicker Strike

---------

Co-authored-by: LocalIdentity <[email protected]>

* Fix Immunities breakdown

* Fix Maata'a Teaching typo

* Fix allocation issue on convert while maintaining node id/name filtering (PathOfBuildingCommunity#6364)

* Fix lower channel time stat using red text (PathOfBuildingCommunity#6381)

* Fix lower channel time stat using red text

* Fix Channel time showing on calcs page for more skills than necessary

---------

Co-authored-by: LocalIdentity <[email protected]>

* Fix "Enemies maimed by you take inc damage over time` not in breakdown (PathOfBuildingCommunity#6400)

The mod was not displaying in the breakdown as it was using the dot flag instead of `DamageTakenOverTime`

Co-authored-by: LocalIdentity <[email protected]>

* Fix Pierce and Chain count config not appearing sometimes (PathOfBuildingCommunity#6401)

* Fix Pierced count config not appearing sometimes

* Fix Chain config not appearing

---------

Co-authored-by: LocalIdentity <[email protected]>

* Regen ModCache

* Fix Snipe damage going negative (PathOfBuildingCommunity#6399)

* FIX: snipe damage going negative

* Set SnipeStacks min value earlier

---------

Co-authored-by: LocalIdentity <[email protected]>

* Null-check node.finalModList when hovering trees (PathOfBuildingCommunity#6408)

Looks like node.finalModList is not initalized when hovering trees, this
simply null checks it.

Closes PathOfBuildingCommunity#6405

Signed-off-by: Tomas Slusny <[email protected]>

* Update 3.22 tree (PathOfBuildingCommunity#6411)

* update tree

* Fix rewording on Chieftain Node

---------

Co-authored-by: LocalIdentity <[email protected]>

* Fix Snipe showing DPS values when triggering support skills (PathOfBuildingCommunity#6415)

Added damage was still contributing to the damage of the skill so it was showing DPS numbers even if the skill was actually dealing no damage
Also removes the debug tooltip I forgot to remove from testing

Co-authored-by: LocalIdentity <[email protected]>

* 3.22 Additions (PathOfBuildingCommunity#6418)

* FEAT: impl more sources of self hit dmg

This code has been moved from PathOfBuildingCommunity#4599 after abandoning cwdt loop support.

* FIX: spelling

* FIX: remove file implemented in PathOfBuildingCommunity#4599

* Add support for non-Boneshatter Trauma

* Add new gems from 3.22 and other stuff

* Fix Crucible Export

* Fix Ruthless support to work with all ailments

* Update for actual support gem

* Support inc stun duration per trauma

* add devour, volatility and locus mine support (PathOfBuildingCommunity#6412)

* add devour, volatility and locus mine support

* Add full support for gems

Add mine tag to Locus Mine
Add support for Anomalous Devour
Fix Mine PvP damage multiplier
Fix flags for damage against full/low life enemies

---------

Co-authored-by: LocalIdentity <[email protected]>

* Spellblade support (PathOfBuildingCommunity#6343)

* Initial spellblade support

* Update label for spellblade damage breakdown

* Update with actual stats and qualities

* Update .txt too

* Floor all final flat values

---------

Co-authored-by: LocalIdentity <[email protected]>

* Fix export

* Add spacing and fix typos

Alter the breakdowns to no longer show the damage taken multi/taken % line if the value has not changed
Added spacing to the lines so you can more clearly read the breakdown when you have multiple taken as elements
Fix some spacing and spelling mistakes

---------

Co-authored-by: Paliak <[email protected]>
Co-authored-by: Lilylicious <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: Regisle <[email protected]>
Co-authored-by: Lily <[email protected]>

* Regen ModCache

* FIX: allow setting inspiration charges to 0 (PathOfBuildingCommunity#6421)

* Add support for Guardian's Blessing no reservation for auras (PathOfBuildingCommunity#6425)

Signed-off-by: Tomas Slusny <[email protected]>

* FEAT: impl sadism less ailment duration mod (PathOfBuildingCommunity#6431)

* FIX: incorrect increased usage mod range (PathOfBuildingCommunity#6434)

* Implement Corrupting Cry support (PathOfBuildingCommunity#6436)

* FEAT: impl Corrupting Cry support

* FIX: crash caused by incorrect capitalization

* FIX: add statMap and baseFlags to txt template

* FIX: spelling

* Revert "FEAT: impl Corrupting Cry support"

* FIX: reimplement using generic physDot

* FIX: copy paste issue

* FIX: cap corrupting blood staged.

Note that this config option also is affected by the one off bug in
config tab code.

* FIX: off by one in the config

* FIX: don't override skillData.durationSecondary

Overriding skillData.durationSecondary of exterted attacks may mess with
secondary effect of skills such as Dominating Blow

* FIX: CorruptingCry cfg stages not affecting exerts

* FIX: crash when hovering over more mult

* change dot type to corrupting blood to prevent dot from stacking

* Remove Attack dot addition + move config

* Fix removal of line

* Empty

---------

Co-authored-by: Paliak <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>

* Add support for new Ancestor uniques (PathOfBuildingCommunity#6426)

* Add mod text only

Signed-off-by: Wires77 <[email protected]>

* Fix Level requirements and add Replica Dragonfang's Flight

* Support Ahuana's Bite

* Support Bound Fate

* Support Kahuturoa's Certainty

* Support Rakiata's Dance

* Fix global gem level/quality name change

---------

Signed-off-by: Wires77 <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>

* Removing allocated mastery from hover list (PathOfBuildingCommunity#6374)

* Removing allocated mastery from hover list

* Updating wording on mastery

---------

Co-authored-by: LocalIdentity <[email protected]>

* Add Ruthless tree (PathOfBuildingCommunity#6367)

* Add support for Ruthless trees

* Fix export URL for Ruthless trees

* Removed data.json

* Fix PR comments

* Fix edge cases around converting and importing

* Updating support for 3rd party ruthless tree links

* Update tree and add Tattoos

* Add support for new Ruthless tree mods

* Fix comment

---------

Co-authored-by: LocalIdentity <[email protected]>

* Support ruthless for poeskilltree

* Optimize itemLib.applyRange, improve startup time (PathOfBuildingCommunity#6407)

* Add applyRange tests

* Optimize itemLib.applyRange, improve startup time

* Fix tree import crash

* Tattoo implementation (PathOfBuildingCommunity#6396)

* Initial tattoo implementation

* Tattoo spec update

* Tattoo export

* Update spec

* Fix spec

* New dat files

* More fixes

* Add artwork, restrict Makanga tattoos

Signed-off-by: Wires77 <[email protected]>

* Fix bug with saving/loading, cleanup code

* Fixed import bug and matched format for save files

* Fixing logic issues preventing proper tattoos from appearing

* Fixed bug with linked node count and supported new tattoo jewel

* Temp fix for effectSprites

* Can't tattoo changed nodes

* Fix tattoo interaction with Timeless jewels

* Update tree, fix more bugs

* Add dropdown search

* Add help text to tattoo dropdown

* Fix stat description error

* Dynamically set popup width

* Made popup width fully dynamic

* Truncate mod lines in tattoo popup

* text wrap in popup

* Dynamic word wrapping, ignoring GGG wrapping

* Revert tree merge

---------

Signed-off-by: Wires77 <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: Peechey <[email protected]>

* Fix secondary effect skills being added as supports (PathOfBuildingCommunity#6393)

* FIX:secondary effect skills being added as support

* FIX: cleanup duplicate code

* Fix Bleed/Ignite Stack potential issues (PathOfBuildingCommunity#6386)

The config was not affecting the number of bleeds/ignites affecting the enemy and was instead only affecting the average roll %
Ignite and Bleed roll % was not calculated to be at least 50% roll as a minimum
Ignite was also not taking into account Hit Chance when calculating the average roll
Breakdowns were improved to show the potential when max stacks is more than 1

Co-authored-by: LocalIdentity <[email protected]>

* Regen ModCache

* Version dropdown QoL (PathOfBuildingCommunity#6365)

* Version dropdown QoL

* ruthless update

* Add support for Fresh Meat Support (PathOfBuildingCommunity#6443)

* Add support for Fresh Meat Support

* Adding general support for increased minion critical strike chance

* Move Config

---------

Co-authored-by: LocalIdentity <[email protected]>

* Implement Sacrifice, Frigid Bond, Guardian's Blessing, Controlled Blaze

* Add initial support for Guardian Minions (PathOfBuildingCommunity#6445)

Adds support for the new Guardian minions to show in the sidebar. The level is manually set to 85 right now as we don't support the `minion_actor_level_is_user_level_up_to_maximum` stat yet

Co-authored-by: LocalIdentity <[email protected]>

* Release 2.32.0 (PathOfBuildingCommunity#6440)

* Prepare release 2.32.0

* Fix changelogs

* Spelling

---------

Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>

---------

Signed-off-by: Tomas Slusny <[email protected]>
Signed-off-by: Wires77 <[email protected]>
Co-authored-by: Wires77 <[email protected]>
Co-authored-by: Regisle <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: Peechey <[email protected]>
Co-authored-by: Tomas Slusny <[email protected]>
Co-authored-by: Lilylicious <[email protected]>
Co-authored-by: Lily <[email protected]>
Co-authored-by: Lancej <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: LocalIdentity <[email protected]>
Beta Release 2.32.0
49febfa 
--- User Interface ---
* Display Cast When damage taken threshold in the trigger rate section

--- Fixed Bugs ---
* Fix Tawhoa's Chosen granting mod being incorrectly parsed
* Fix Tawhoa's Chosen not working with strike skills
@Paliak
FIX: null deref at slotMatch (PathOfBuildingCommunity#6451)
032940d
@Wires77
Fix editing tattoo under timeless jewel influence (PathOfBuildingComm…
47fa91e 
…unity#6450)
Beta Release 2.32.1
07534c9 
--- Fixed Bugs ---
* Fix crash when opening some minion builds (Paliak)
* Fix Timeless jewel stats disappearing when applying a tattoo (Wires77)
@Paliak @Wires77
FIX: crash caused by incorrect breakdown table (PathOfBuildingCommuni…
8fdb46a 
…ty#6452)
@Wires77
Update release.yml
13060e7
@Wires77
Fix lua error when hovering Ascendant nodes (PathOfBuildingCommunity#…
353550a 
…6454)
@Wires77
Update release.yml version bump
41df68e
@Wires77
Prepare release 2.32.2
0fbd80e
@LocalIdentity LocalIdentity changed the title Merge beta into dev Rework the way Triggers are calculated Aug 24, 2023
@LocalIdentity LocalIdentity merged commit dc7aeef into PathOfBuildingCommunity:dev Aug 24, 2023
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
@Paliak Paliak deleted the mergeBetaIntoDev branch January 20, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Paliak @LocalIdentity @Wires77