New stuff from Ancestor To Do

[Paliak]

Implements the following mods:

• Enemies you kill have 5% chance to explode, dealing 500% of their maximum Life as Fire Damage
  I added another line to keep the match string simpler but this maybe could be done by modifying the existing one.

• Skills from equipped Body Armour are supported by Level 30 Ancestral Call
Skills from equipped Body Armour are supported by Level 20 Fist of War
  I moved the code from the socketed [%a+]* ?gems a?r?e? ?supported by level (%d+) (.+) line handling the extra support mod creation into a function and added the ability to pass a slot string. Tested with both the new mods and a few old ones and it seems to work correctly.

• Grants Armour equal to 25% of your Reserved Mana to you and nearby Allies

• Auras grant 5% increased Recovery Rate of Life, Mana and Energy Shield to you and allies
  Handled with piece wise parsing.

• Elemental Damage with Hits dealt by Allies between you and Linked Targets is Lucky

• Allies between you and Linked Targets have +5% to all maximum Elemental resistances
  Handled with piece wise parsing. Uses the "Is the enemy in the way of a Link skill?" config option (possibly misleading?).

• Enemies between you and Linked Targets cannot apply Elemental Ailments
  The implementation for this mod could likely be generalized but i was not able to make it work. Implemented by setting player ailment avoid chance to 100%.

• 10% of Damage from hits is taken from Sentinel of Radiance's life before you

• Nearby Enemies have no Fire Resistance against Damage over time while you are stationary
  Implemented using generic "no" mod modForm. This allows the ModParser to piece wise parse similar mods.

• Modifiers to Maximum Fire Resistance apply to Maximum Cold and Lightning Resistances
  Should work for any combination of resistances. The implementation should be simplified by using a hard coded constant but i wanted to make it more flexible.

• Modifiers to Fire Resistance apply to Cold and Lightning Resistances at 50% value
  Similar to above

• Non-unique Jewels cause Increases and Reductions to other damage types in Large radius to be Transformed to apply Fire Damage
  Due to the way it's implemented the mod only works if it comes from a node on the tree. This should be fine since it's an ascendancy node.

• +910 to maximum Life if there are no Life Modifiers on other Equipped items
  The chieftain jewel mod required a rework of the ItemCondition code in ModStore.lua so i added support for allSlots and excludeSelf flags while there.

Adds new config options:

• conditionHaveRadianceSentinel
  "Do you have a Sentinel of Radiance?"
• conditionBetweenYouAndLinkedTarget
  "Is the enemy in the way of a Link skill?"
  This one could maybe use better wording.

Adds the following items to the New.lua file

Kitava's Hunger
Majestic Plate
88% increased Armour
Recover 2% of Life on Kill
37% Increased Stun and Block Recovery
+910 to maximum Life if there are no Life Modifiers on other Equipped items

Should be fully supported.

Arohongui's Tending
Coral Amulet
Regenerate 4.4 Mana per second
37% increased Life Recovery from Flasks
26% increased Mana Recovery from Flasks
Life Flasks used while on Low Life apply Recovery Instantly
Mana Flasks used while on Low Mana apply Recovery Instantly

Instant recovery mods are not supported but don't seem to be supported on flasks either. I'm not sure if there's a point in supporting those in POB

Bound Fate
Cloth Belt
+28 to Dexterity
+26 to Intelligence
+64 to Maximum Life
Every 5 seconds, gain one of the following for 5 seconds:
Your Hits are always Critical Strikes
Hits against you always are Critical Strikes
Attacks cannot Hit you
Attacks against you always Hit
Your Damage with Hits is Lucky
Damage of Hits against you is Lucky

I'm not sure what would be the correct way of supporting the temp mods here. For now i've disabled lucky damage mod by replacing spaces with nbsp.

[Nostrademous]

LGTM

[Wires77]

10% of Damage from hits is taken from Sentinel of Radiance's life before you
This could maybe be possible to implement like frost shield. Currently implemented with a generic less damage taken mod.

Looking at the code this doesn't seem accurate anymore, fixed in 0784fa1 correct?

[Wires77]

For the rotating mods, I really dislike the nbsp "fix". Would much rather make each one a variant instead, because a year from now no one is going to understand why that isn't working. I'll change that, add the new unique (wording only), and update the wording for the lines that have changed.

Is the "no" ModForm still needed now that the wording changed to "is 0%" now?