Fix Life Mastery item condition to include Enchants #6068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason we don't t_insert for all mods and overwrite instead? Because if you craft a magic body armour, give it max life prefix and add a non-life harvest enchant, the bug still exists with this change because the quality enchant index overwrites the life prefix index.
|
|
@Peechey I have no idea why it was done like that... fixed. |
LocalIdentity
approved these changes
Apr 22, 2023
3 tasks
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…mmunity#6068) * Fix Life Mastery item condition to include Enchants * fix over-write to use table insert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6064
Description of the problem being solved:
Adds crafted enchantment conditions to modifiers being considered in item conditionals.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Same as in Issue
Before screenshot:
After screenshot: