Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"15% increased maximum Life if there are no Life Modifiers on Equipped Body Armour" life mastery applying incorrectly with implicits #6113

Closed
3 tasks done
GKingsbury opened this issue Apr 23, 2023 · 1 comment
Labels
bug: behaviour Behavioral differences

Comments

@GKingsbury
Copy link

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Check for support

  • I've checked that the behaviour is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What is the behaviour in-game?

The 15% increased maximum Life if there are no Life Modifiers on Equipped Body Armour life mastery looks at both explicit and implicit modifiers. Applying an implicit to your body armor with the life tag (ie #% increased Life Recovery rate) does count as a life modifier and causes the mastery to not apply.

What is the behaviour in Path of Building?

Currently, Path of Building does not count eldritch implicit tags when applying the mastery. In the provided example, I have the #% increased Life Recovery rate implicit. In game, this lowers my health to 4347. In Path of Building, it incorrectly applies the life mastery selected for a total of 4642 life.

How to reproduce the issue

  1. Create a body armor with no explicit life modifiers and wear it
  2. Take the 15% increased maximum Life if there are no Life Modifiers on Equipped Body Armour life mastery
  3. Note your health while no life tags are on the body armor
  4. Apply the #% increased Life Recovery rate implicit using eater of worlds currency to the body armor
  5. Note that your health drops as the mastery is no longer applying

Character build code

https://pastebin.com/9em28cGT

Screenshots

No response

@GKingsbury GKingsbury added the bug: behaviour Behavioral differences label Apr 23, 2023
@QuickStick123
Copy link
Contributor

This is fixed in dev (or beta branch if it has updated) by #6068 and will be in the next update.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

No branches or pull requests

3 participants
@GKingsbury @QuickStick123 and others