Add support for Sandstorm Visage crit mod #5398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbelu
changed the title
|
Minor note the way you implemented it the mod would be considered baseCritFromMainHand as the application to spells is handled exclusively by the config and spell tag. |
|
Fair enough, perhaps in future use cases it may come into play. Updated |
|
Fixes #5342 |
LocalIdentity
approved these changes
Dec 19, 2022
|
Just tested this on the dev branch, for me it doesn't work with the showcased build |
|
It works you probably forgot to rebuild mod cache Testing this mechanic ingame saw unarmed setting base crit on spells to 0% which this doesn't do. |
1 task
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 26, 2022
* Add support for Sandstorm Visage crit override * Add breakdown message * Change name of base crit from weapon var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Add support for Sandstorm Visage main hand crit -> spell base crit
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pastebin.com/KVyAewuk
After screenshot: