Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Sandstorm Visage's "Base Critical Strike Chance of Spells is the Critical Strike Chance of your Main Hand Weapon" #5342

Closed
1 task done
QuickStick123 opened this issue Dec 14, 2022 · 1 comment
Closed
1 task done

Add support for Sandstorm Visage's "Base Critical Strike Chance of Spells is the Critical Strike Chance of your Main Hand Weapon" #5342

QuickStick123 opened this issue Dec 14, 2022 · 1 comment
Labels
enhancement New feature, calculation, or mod

Comments

@QuickStick123
Copy link
Contributor

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

image
Base crit of spells is main hand crit is not supported on sandstorm visage

Describe the solution you'd like

Spell's base crit is overwritten by mainhand crit

Describe alternatives you've considered

No response

Additional context

No response
@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Dec 14, 2022
@QuickStick123 QuickStick123 mentioned this issue Dec 19, 2022
Merged
@QuickStick123
Copy link
Contributor Author

Fixed by #5398

@Pegoth Pegoth mentioned this issue Dec 30, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@QuickStick123