Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max calculcated fuses for Expl Arrow to calcs #5209

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Add max calculcated fuses for Expl Arrow to calcs #5209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c77ebd0
Add max calculcated fuses for Expl Arrow to calcs
dbronkalla06 Dec 6, 2022
e7adab5
Merge branch 'dev' into temp
Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Modules/CalcOffence.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1715,6 +1715,7 @@ function calcs.offence(env, actor, activeSkill)
globalOutput.TheoreticalMaxOffensiveWarcryEffect = 1
globalOutput.RallyingHitEffect = 1
globalOutput.AilmentWarcryEffect = 1
globalOutput.MaxExplosiveArrowFuseCalculated = 1

if env.mode_buffs then
-- Iterative over all the active skills to account for exerted attacks provided by warcries
Expand Down Expand Up @@ -2051,6 +2052,9 @@ function calcs.offence(env, actor, activeSkill)
local maximum = m_min(hitRate * duration, skillMax)
skillModList:NewMod("Multiplier:ExplosiveArrowStage", "BASE", maximum, "Base")
skillModList:NewMod("Multiplier:ExplosiveArrowStageAfterFirst", "BASE", maximum - 1, "Base")
globalOutput.MaxExplosiveArrowFuseCalculated = maximum
else
globalOutput.MaxExplosiveArrowFuseCalculated = nil
end

-- Calculate crit chance, crit multiplier, and their combined effect
Expand Down
1 change: 1 addition & 0 deletions src/Modules/CalcSections.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,6 +654,7 @@ return {
{ breakdown = "BrandAttachmentRange" },
{ modName = "BrandAttachmentRange", cfg = "skill"},
}, },
{ label = "Max Sust. Fuses", haveOutput = "MaxExplosiveArrowFuseCalculated", { format = "{0:output:MaxExplosiveArrowFuseCalculated} Fuses", }, },
{ label = "Trap Throw Rate", flag = "trap", { format = "{2:output:TrapThrowingSpeed}",
{ breakdown = "TrapThrowingSpeed" },
{ modName = "TrapThrowingSpeed", cfg = "skill" },
Expand Down