Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max calculcated fuses for Expl Arrow to calcs #5209

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

dbronkalla06
Copy link
Contributor

Description of the problem being solved: Expanding upon the ability for PoB to automatically calculate the max number of sustainable fuses for Explosive Arrow that was in #4918 to add the number of sustainable fuses to the calcs tab. When leveling through an EA build, I was curious as to how many fuses I could sustain but only saw the overall damage go up but had to calculate by hand the number of fuses.

Steps taken to verify a working solution:

  • Import build with EA skill. Toggle between Max Sustainable Fuses and manually setting fuses
  • Confirm the value does not show when you don't have Max Sustainable Fuses selected for the skill part on the calcs tab

Link to a build that showcases this PR:

https://pobb.in/ESk0PXDoIwGu

Before screenshot:

image

After screenshot:

image

@dbronkalla06 dbronkalla06 marked this pull request as ready for review December 6, 2022 21:11
@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Dec 6, 2022
@LocalIdentity LocalIdentity merged commit 707a490 into PathOfBuildingCommunity:dev Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants