Display resource costs per second #5199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuickStick123
suggested changes
Dec 7, 2022
|
This was the only other odd behaviour but it is nothing to worry about |
Co-authored-by: QuickStick <[email protected]>
LocalIdentity
approved these changes
Dec 8, 2022
Paliak
added a commit
to Paliak/PathOfBuilding
that referenced
this pull request
Dec 8, 2022
Wires77
pushed a commit
that referenced
this pull request
Dec 9, 2022
* FEAT: Stop disabling aura effects when unreserved mana is negative. Add a warning for when LifeCost or ManaCost is higher than avilable pool. * FEAT: Make mana cost warnings show for all enabled active skill gems not just mainSkill. * FIX: generalize match condition for cost coloring. * FIX: Add support for mana cost warning for triggered skills. * FIX: fix copy paste typo. * FEAT: implement warnings for energy shield and rage cost. Minor tweaks. * Apply suggestions from code review Co-authored-by: QuickStick <[email protected]> * FIX: Add better handling for eldrich battery. Minor tweaks. * FIX: fix other costs missing from top level cache table. * FIX: add compatibility with #5199 Co-authored-by: QuickStick <[email protected]>
LocalIdentity
pushed a commit
that referenced
this pull request
Dec 9, 2022
… costs. (#5247) * FEAT: Stop disabling aura effects when unreserved mana is negative. Add a warning for when LifeCost or ManaCost is higher than avilable pool. * FEAT: Make mana cost warnings show for all enabled active skill gems not just mainSkill. * FIX: generalize match condition for cost coloring. * FIX: Add support for mana cost warning for triggered skills. * FIX: fix copy paste typo. * FEAT: implement warnings for energy shield and rage cost. Minor tweaks. * Apply suggestions from code review Co-authored-by: QuickStick <[email protected]> * FIX: Add better handling for eldrich battery. Minor tweaks. * FIX: fix other costs missing from top level cache table. * FIX: add compatibility with #5199 * FIX: mana warnings showing up when using EB * FIX: remove per second cost warning Per second cost warnings are hard to make accurate to due the amount of recovery sources avilable both in poe and in pob. Co-authored-by: QuickStick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5144
Description of the problem being solved:
This PR reuses the resource cost per second code added for link skills. If the selected skill does not currently have a cost per second, but it does have a static cost as well as a attack/cast speed or a cooldown, calculate and display the cost per second.
Steps taken to verify a working solution:
All of the above work as expected, including when mana/speed/cooldown are changed.
Link to a build that showcases this PR:
Literally any, but https://pobb.in/g6747fS_PsdW
Before screenshot:
After screenshot: