Add warnings if skill cost exceeds avilable resource #5019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a warning for when LifeCost or ManaCost is higher than avilable pool.
Closed
2 tasks
Co-authored-by: QuickStick <[email protected]>
…ilding into manausagewarning
|
Text warning for life/energy shield now doesn't seem to appear. Everything else seems fine. |
|
@QuickStick123 I assumed other costs would be in the top level of the cache table too but that was not the case. 946c47e should fix it. Thanks for the help. |
Paliak
changed the title
QuickStick123
approved these changes
Sep 18, 2022
There was a problem hiding this comment.
LGTM the only remain issue is output.Rage doesn't exist in current dev.
This can be added here as well or can just wait until #5011 is merged. Up to you.
|
@QuickStick123 I made it default to 0 if output.Rage is nil so i think it's fine if it stays separate. |
|
This will need a couple fixes for conflicts generated by #5199 being merged |
Wires77
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4998 .
Description of the problem being solved:
Currently there is no warning that a skill uses more life/mana/Es/Rage than is available. This pr also stops auras from not applying their effects even though reservation is applied even when above possible reservation.
Note that this pr makes triggered skills get cached. This may or may not cause issues with some calculations but i was not able to find any issues.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: