Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Absolution spell hit counted multiple times in the Total DPS #4653

Merged
merged 6 commits into from
Dec 9, 2022
Merged

Fix Absolution spell hit counted multiple times in the Total DPS #4653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9112c68
bugfix: Count Absolution spell hit once in the Total DPS
APXEOLOG Jul 27, 2022
b687cdb
bugfix: Modify info message for better clarity
APXEOLOG Jul 27, 2022
b826d3c
bugfix: Fix spacing
APXEOLOG Jul 27, 2022
15f84ba
bugfix: Fix spacing
APXEOLOG Jul 27, 2022
607ccee
bugfix: Fix spacing
APXEOLOG Jul 27, 2022
e4543b3
Add config option
APXEOLOG Jul 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/Modules/Calcs.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,11 @@ function calcs.calcFullDPS(build, mode, override, specEnv)
if usedEnv.minion.output.CullMultiplier and usedEnv.minion.output.CullMultiplier > 1 and usedEnv.minion.output.CullMultiplier > fullDPS.cullingMulti then
fullDPS.cullingMulti = usedEnv.minion.output.CullMultiplier
end
-- This is a fix to prevent Absolution spell hit from being counted multiple times when increasing minions count
if activeSkill.activeEffect.grantedEffect.name == "Absolution" and fullEnv.modDB:Flag(false, "Condition:AbsolutionSkillDamageCountedOnce") then
activeSkillCount = 1
activeSkill.infoMessage2 = "Skill Damage"
end
end

if activeSkill.mirage then
Expand Down
3 changes: 3 additions & 0 deletions src/Modules/ConfigOptions.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,9 @@ return {
modList:NewMod("Condition:WaveOfConvictionLightningExposureActive", "FLAG", true, "Config")
end
end },
{ var = "absolutionSkillDamageCountedOnce", type = "check", label = "Absolution: Count skill damage once", ifSkill = "Absolution", tooltip = "Your Absolution Skill Damage will not be scaled with Count setting.\nBy default it multiplies both minion count and skill hit count which leads to incorrect\nTotal DPS calculation since Absolution cannot inherently shotgun.\nDo not enable if you use Spell Totem support, Spell Cascade support or similar supports", apply = function(val, modList, enemyModList)
modList:NewMod("Condition:AbsolutionSkillDamageCountedOnce", "FLAG", true, "Config", { type = "Condition", var = "Combat" })
end },
{ label = "Molten Shell:", ifSkill = "Molten Shell" },
{ var = "MoltenShellDamageMitigated", type = "count", label = "Damage mitigated:", tooltip = "Molten Shell reflects damage to the enemy,\nbased on the amount of damage it has mitigated.", ifSkill = "Molten Shell", apply = function(val, modList, enemyModList)
modList:NewMod("SkillData", "LIST", { key = "MoltenShellDamageMitigated", value = val }, "Config", { type = "SkillName", skillName = "Molten Shell" })
Expand Down