Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Absolution spell hit counted multiple times in the Total DPS #4653

Conversation

APXEOLOG
Copy link
Contributor

@APXEOLOG APXEOLOG commented Jul 27, 2022

Description of the problem being solved:

While calculating Full DPS for Absolution the Count increases not only the number of minions (which is correct) but also multiplies the dps of the spell itself (which is incorrect)

Steps taken to verify a working solution:

  1. Add Absolution active skill
  2. Increase count
  3. Check Include in Full DPS

Link to a build that showcases this PR:

https://pobb.in/-aL0wEIoqGe_

Before screenshot:

image

After screenshot:

image

image

@APXEOLOG APXEOLOG changed the title bugfix: Count Absolution spell hit once in the Total DPS Fix Absolution spell hit counted multiple times in the Total DPS Jul 27, 2022
@deathbeam
Copy link
Contributor

Is this correct tho? This breaks full dps counter for non-minion absolution (1 example would be spell cascade or totems etc)

@APXEOLOG
Copy link
Contributor Author

Is this correct tho? This breaks full dps counter for non-minion absolution (1 example would be spell cascade or totems etc)

This is a valid concern. In that case, the best approach will be to implement a separate counter for minions. Do you know if there is any flag I can use to differentiate the skills which deal direct damage but still spawn minions from the skills which just spawn minions?

@QuickStick123 QuickStick123 added the bug: behaviour Behavioral differences label Jul 27, 2022
@APXEOLOG
Copy link
Contributor Author

APXEOLOG commented Jul 28, 2022

I've added a config option (disabled by default) to control behavior of the change
image

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wires77 Wires77 merged commit 81d715f into PathOfBuildingCommunity:dev Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: behaviour Behavioral differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants