Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sacrificial Zeal buff conditional configuration checkbox #8421

Closed
1 task done
grish333 opened this issue Jan 20, 2025 · 0 comments · Fixed by #8481
Closed
1 task done

Sacrificial Zeal buff conditional configuration checkbox #8421

grish333 opened this issue Jan 20, 2025 · 0 comments · Fixed by #8481
Labels
enhancement New feature, calculation, or mod

Comments

@grish333
Copy link

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

Is your feature request related to a problem?

It is not related to an actual problem but is a good quality of life feature that meets all the requirements to be there.

Describe the solution you'd like

The default state considers the player having this buff constantly but there should be an additional checkbox configuration where it would allow you to check/uncheck a Sacrificial Zeal buff which is granted by Hand of the Fervent gloves.
I checked all the possible conditional configurations but it doesn't exist there. Please add it :)

Describe alternatives you've considered

No response

Additional context
@grish333 grish333 added the enhancement New feature, calculation, or mod label Jan 20, 2025
@Paliak Paliak mentioned this issue Feb 14, 2025
Merged
@MarcoCap MarcoCap mentioned this issue Mar 2, 2025
Closed
2 tasks
Paliak added a commit to Paliak/PathOfBuilding that referenced this issue Mar 2, 2025
@Paliak
FIX!: Sacrificial Zeal no longer default on
e85c4be 
Initially when trying to fix issue
PathOfBuildingCommunity#8421 i
made the config default enabled to maintain current behaviour of it
being on the moment Hand of the Fervent was equipped. I was under the
impression that the ifFlag would prevent the config application function
from running but that doesn't not seem to be the case. I've tried a few
different ways of fixing this but i've decided that the best course of
action would be to simply make the effect opt in rather than opt out.
@Paliak Paliak mentioned this issue Mar 2, 2025
Merged
LocalIdentity pushed a commit that referenced this issue Mar 5, 2025
@Paliak
FIX!: Sacrificial Zeal no longer default on (#8542)
c1c81cf 
Initially when trying to fix issue
#8421 i
made the config default enabled to maintain current behaviour of it
being on the moment Hand of the Fervent was equipped. I was under the
impression that the ifFlag would prevent the config application function
from running but that doesn't not seem to be the case. I've tried a few
different ways of fixing this but i've decided that the best course of
action would be to simply make the effect opt in rather than opt out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add checkbox for Sacrificial Zeal Paliak/PathOfBuilding
1 participant
@grish333