Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sacrificial zeal is enabled by default (even without equipping Hand of the fervent) #8541

Closed
2 tasks done
MarcoCap opened this issue Mar 2, 2025 · 0 comments · Fixed by #8542
Closed
2 tasks done
Labels
bug Something isn't working

Comments

@MarcoCap
Copy link

MarcoCap commented Mar 2, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

What platform are you running Path of Building on?

Windows

How is Path of Building expected to behave?

Sacrificial zeal is not enabled and/or has no effect unless Hand of the Fervent is currently equipped.

How does Path of Building behave?

Per title, when creating a build from scratch, the "Sacrificial Zeal" checkbox in configuration is

  • enabled by default
  • hidden unless the character has Hand of the Fervent equipped.

This leads to the buff being applied for no apparent reason. Equipping the gloves, unticking the checkbox and unequipping them brings the situation to a stable state.

This PR does not (completely) fix the previous similar issue since the checkbox is there, but it should be off by default.

How to reproduce the issue

Create a new build, equip any spell skill gem (that uses mana), it will have added physical damage with cause "Sacrificial Zeal".
Associated build has been created by clicking "new build", adding ethereal knives and no other step.

Version 2.52.3

PoB for PoE1 build code

eNqtW1t32roSfm5_hRfvDWAuSfYi3YsEclk7aTiQtuc8dQlbgHZkiW3LSdi__owk2xiKjIydhxbQfHOVRjODGfz5EVDnDYcR4eyq0T5rNRzMPO4TtrxqfH-5_XLR-PPr58EEidXz4jomVK58_fxpoF47FL9hCriGI1C4xOJHyqnzCzitERMrzNkT-puHd9y_anzjDDecOWI-Eek7j6Io-oYCfNWYeQBuOCjyMPNvtp8nhCsUIk_g8FFKHcaCP3EfVkUYw2qACJtx7xWLu5DHa6XUG8HvmubhafI8fcmpRFheJbDo02BC0QaHM4GEE8E_V40hOAYt8T0RwArRGPi03f5Zu9t3W73LdrfVbzQLkddxGIkRCuBlWQ6zNcb-FnTWz_2dm0CTEI8XC-wJ8oZvQiJuVoh5W9FGYWVpn2IqyJoSHOY07JkQ978xb7daJuIXLhAdTWYZrdtunbndTv-833M73U4xjm8jZZTwk4jVNQXvniBFYh-WjAh8InjCScRZBfvyUKOJNzGlcE6taKc4wuEbEmRXLTNvHswJO8l7T4ihGx5tY-S2ikgnOIQ8IHYQxwAz7HFIHXlIp3PWyf1ZSDzMxyj6kSywPWUpqxJAWW1Os2M8s6Urzfg0haaQN-0oZzymlpQitNh-I_xhQTXF_-QJLy9MhA9M2LHLE_YvzNq9caFuymPWqqwxvp9sD8PFmetett3z1vm5a8zYk9UmIh6iT-iDBHEACfwFveKtvH7B7luuBIPcY4J2jJfXLQlxedQNp_4JqBXikRF2UXS2LJwAd7f3h6R9YJ7dgf3OQpWGc1d-vxAwhWMka4w5xZaIrYjkMNrcxlrUErNE3sbOnEeMvdUdFGRTJLBd7s6oesVulbRWbpWEB9zaswSUcJIEGpx0dlkEKummMcPhcjNbEUz9ctSpYjdobZEhpZvzaCt374ortWPy0JIu-YlC3-4eKavTG4ryGbbdL3aXJrfbmBiKTwD4eK8qbpnLev63LOppOdgwDHgcWgZcE1sZkN4OurGZYj_27G6jrDe5ptCo2ZqRoUBPSktBh0Ig73XE_aW105SQUohd_Wbxeg05RO4GWwby4oMqnOTKly99C-pn2MpWJ1rekfYCttTWArJb317KHsTeFnlzlzBmS24tIgvoEySLAC4B1Ys_8Vw7bgwONF5WXZQitOzmJvwdNF_JAUtUjhoqnG1VY1QlxOzfjTX_HXIrAWPmx6E8CtYy9hGHxLyQABJpFI2QQI6fVMQ_UEgQE66a_kQYhd7qEUJ_iyidQya4auQ_le_2gO00toOmGnDJVw_BmofCwR_yvwkKxeaqsUA0wppQfQJ8IkGY6qIh7VDacGYr_j7036QVL5zTKAU5aL3GzN_h8RJi7KA0iXhSCWWjfOMEKBJwZ-ldGUmlc_OxB1-60WEcFIDi5uICGlwwUfZYKNwMdwkZAb0EyMqN6aAJ0BM4zUmK_TT4Pn1ULz6thFhHfzSb7-_vZ2skVnyBP-AaOvN40FwDCBT-Er0SSr9Its0h_F0vh-pPMWqmnAZ6NBc19Tt5FkMCOutYNqWhyuvSE_LFNy5wJNfkh-mbwUyKipwIAnGHg-h6A-fnVpYNe2OJxJWSeoaF3gx5TDoz9PECxVR-_p8YUSIj28p_-qjHm4yHQdYMASuIrEzzmuPLZi1dP3x81CtDKhJmUlwaZh3ORCGH-GmIkw_V9HK41foGUS9SehPm0diHTiJJLUkUKZpLzeS0VvYAfn4KmuOTifk0AG0S4jvK54i6KSSZ4UJf6ixxILfBExbIh2PVfBBgQlPa0VTs4NVYrHCIEf2LgQx1lNXBkbD9JbUxDi38k3N28lqSjbTfGztqtlM19wz1eMx0ZBkKklOTynESQclm07onGy0JgdpsejvJl8rfiuKBrWOheF41AhJ5v-bxYiFnyGCPCNVYfHx7O755efgxTjJRHqJs_sXiYC5no_r_7X0xw6pScqJ4HumXV40fBL8rRUbgdUIjaRqlaB3hLEeo_ZJoTgFXwE1RQUebDp0P89oSmDmNP3AIKW0JJbYXEmzUK1s_opQWKMtvmblN3OQE18xI13M3kBB1e2DwlBqdm7nICbbRHLlYgIXLAFGj5GT1iCeEzBiwYcmCePLSKw65zC-aqsAvngf3pbcpiHdSjJp5qJG4iYFeNIP1WNuETlYLvKpG6kav6lUzfIQ9ZLRdL5rBWcfJmfqi5zCXjKqA0zfO1CaHQzMkVBaOxsiOKc5IzAyfZT5L7n0TpyfIUSlJ4cEJyTwW5mOcoyjwlZp_GTwk18xQPeMx2CDXCjLRztzD4NA8jZmVnhcYE1kRVDcRRv8lLUlBCJJu3OB-vVrghHQgYbA_WS44JCr_Dt848XVbajgue2RFCQNKuupsVK9dnc1-812d4y1Uxa_GeCerZvh3QWRhc4CLLmCsmMhDVY2DPFvVOLxACSriEJ_MYLpfiWyx0-IaJGsYD4LT1aLMkfSRJ3PQ3e7JcNWMn4xW-R-qYgwWFF4AGU3B-RAxG4EzRMHZsGSl1DqcSLbWleKlr8KDlpbmqA948o1OUQ7QJEcYwV1-X1At2nHKBkr30JzIZwA4rcbwt2-uqjCTQ_F4jZifsns-VKNv42DpPS4i4KmmKCM5e6_qQ4aDzQFGZr0GzbSrU_MV2Wclw5-ZCGXr_C_nwf9UEypfJb1-J-nvoeIeEYhbqPZbKkcS_jcdXA1Ue5wMG-TrbNZgZhBHWH8D_hOjNWcKIRt63UhqHkai3bkB5cKBujiYzL9PH6U9ugOFtlk12XJJz3SaxQAtxGmXgFxziK4znG-iCLptPdpxemUYYCr28W4JvLpznM4JVjqzd7TeF909hVEF8xMebg08DhvUr8Ggfg0GncTjkEGVd2enBo-4dVlTZr_dY7gcRSV_HDhs_coauKU5VBbZqcv_vRo2Q7uG49GuQY9uyZ1QV4pxq57Ibg0OLH9n1JZiO1Xtdyse4XIK-BtHzxiq7EFdW1ThcPhg9ypz6NcV1nZdOab81qzux27lWPbq2VRljB8GMcWihkzYqSGhdCoeym5FfLse_598U5betN3SiFOqqIpe7VXN1TWFpVtXcqmtrj65hSqBmxK2LBXCw6nJrScGtd0UdTR83dNsKuv86nd8TcVGr7Ii1a-4ftlkUDV5_C5w0ExGPWpMpcZI6ikEzhZkmQyU9JtkpKRA2Sc7c6AJRR5ecerjMFECy1FZ8vux9AmE81amuwGw82BdCuscQ2WP8aUPHKRI1-22j0nM_eoshfWOYPLPSmaYo6bBJyfoJ2WdAFODxC3iomumD7Lf0cnfhuEQ-zP1gIN8tmWG6SL3BEnPwsbSjsmiN5FD5CzotqjygZB7bN-lF5f9I7Dsu8_MG612t2PhEFuzIrIk9Hmhvq2BCKivnPae3TkEm3lcTZMhZHYApVjy2DSndIpY3hHnx9yXJv8U0G9fXlxaHLJ9jx891btPeJc-NLZun60gQRrcN2hm6U7P8tW7r58Hzf3fIv8fOxFnRw==

Screenshots

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant