Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports granted by items (Cast on Crit) not working on trigger gems #21

Closed
foschw opened this issue Dec 8, 2019 · 2 comments
Closed

Supports granted by items (Cast on Crit) not working on trigger gems #21

foschw opened this issue Dec 8, 2019 · 2 comments
Labels
enhancement New feature, calculation, or mod

Comments

@foschw
Copy link

foschw commented Dec 8, 2019

Currently when using e.g. a shaped sword which grants cast on crit the main gem does not link properly. In effect the mana cost calcuations are off - i.e. the mana cost of my cyclone (https://www.pathofexile.com/account/view-profile/platin91x/characters/platin_yikes) is calculated to be 3 but is 4 in reality (before reduced mana gear).
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Dec 31, 2019
@Nostrademous
Copy link
Contributor

Hopefully fixed by #2294

@Nostrademous
Copy link
Contributor

Fixed in 2.0.0

markoleptic added a commit to markoleptic/PathOfBuilding that referenced this issue Dec 12, 2023
@markoleptic
Added gems from lines 564-623 (PathOfBuildingCommunity#21)
e28dbf8
Wires77 added a commit that referenced this issue Dec 15, 2023
@Nostrademous @markoleptic
@asvanberg @Wires77
Add support for many transfigured gems (#6984)
f391c81 
* WIP

* WIP 2

* WIP 3

* WIP 4

* Add stated transfigs

* fix minion parsing

* remove a print out

* extra tests for stuff

* implement when more stat sets than skill levels exist

* fix using wrong player level req

* added transfigured gems through GemEffects.DAT row #65

* added transfigured gems through GemEffects.DAT row #140

* added transfigured gems through GemEffects.DAT row #275

* added transfigured gems through GemEffects.DAT row #500

* added transfigured gems through GemEffects.DAT row #564

* fix \n in active gem descriptions

* Added gems from lines 564-623 (#21)

* added transfigured gems through GemEffects.DAT row #868 - END

* Finish Adding Transfigured Gems (#22)

* Added gems from lines 564-623

* Finish adding transfigured gems

* Remove StormBrandAltY since it doesn't exist

* all transfigured gems exported

* enhancements

* added new Carrion Golem skills

* gave new Carrion Golem skills names

* add minion spells

* spelling fix

* cleanup level/stats iteration code for gems

* Update almost all dex gems

Gems without support are:
Blink / Mirror Arrow variants
Storm Rain

* Fix Static Strike Quality

Fixes #7031

* 3.23.0b export

* Add support for Ball Lightning of Static

* Update stat describer for invert_chance and divide_by_one_hundred_1dp

* Fix statDescriptionScope + Stats tables on some gem exports

The statDescriptionScope was defaulting to `skill_stat_descriptions` instead of copying the scope from the base gem variant
The new Transfigured gems inherit the base damage scaling from the base gem and use negative values to adjust for the Transfigured version

* Fix indenting

* Remove old code supporting Divergent Ball Lightning

* Update almost all str skills

* Update Vaal Cleave Buff

* Fix spelling

---------

Co-authored-by: Mark Cunningham <[email protected]>
Co-authored-by: LocalIdentity <[email protected]>
Co-authored-by: Andreas Svanberg <[email protected]>
Co-authored-by: Wires77 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Nostrademous @foschw @LocalIdentity