Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for many transfigured gems #6984

Merged
merged 42 commits into from
Dec 15, 2023

Conversation

Nostrademous
Copy link
Contributor

Export update to enable Transfigured Gems.

Example add of PoisonArrowAltX

Nostrademous and others added 30 commits December 10, 2023 15:31
* Added gems from lines 564-623

* Finish adding transfigured gems

* Remove StormBrandAltY since it doesn't exist
Gems without support are:
Blink / Mirror Arrow variants
Storm Rain
LocalIdentity and others added 9 commits December 14, 2023 17:27
The statDescriptionScope was defaulting to `skill_stat_descriptions` instead of copying the scope from the base gem variant
The new Transfigured gems inherit the base damage scaling from the base gem and use negative values to adjust for the Transfigured version
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Dec 14, 2023
@Wires77 Wires77 changed the title New export code Add support for many transfigured gems Dec 15, 2023
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs some refinement of the save format, but I'm going to merge it into dev to make it easier for other contributors to find and make changes.

@Wires77 Wires77 merged commit f391c81 into PathOfBuildingCommunity:dev Dec 15, 2023
@Nostrademous Nostrademous deleted the NewExportCode branch December 15, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants