-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for many transfigured gems #6984
Merged
Wires77
merged 42 commits into
PathOfBuildingCommunity:dev
from
Nostrademous:NewExportCode
Dec 15, 2023
Merged
Add support for many transfigured gems #6984
Wires77
merged 42 commits into
PathOfBuildingCommunity:dev
from
Nostrademous:NewExportCode
Dec 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g into NewExportCode
* Added gems from lines 564-623 * Finish adding transfigured gems * Remove StormBrandAltY since it doesn't exist
Gems without support are: Blink / Mirror Arrow variants Storm Rain
The statDescriptionScope was defaulting to `skill_stat_descriptions` instead of copying the scope from the base gem variant The new Transfigured gems inherit the base damage scaling from the base gem and use negative values to adjust for the Transfigured version
Wires77
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs some refinement of the save format, but I'm going to merge it into dev
to make it easier for other contributors to find and make changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export update to enable Transfigured Gems.
Example add of
PoisonArrowAltX