Improve EHP accuracy #552
Merged
Improve EHP accuracy #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been testing in what order damage types get calculated when losing resources to a hit with multiple damage types. The tests lead me to believe that when losing guard chaos damage comes last (so probably goes by conversion order); when losing ES chaos damage comes first (so probably reverse conversion order). I've been testing this with heartbound loop + infernalists altered flesh for 20% phys taken as chaos + charms with guard rolls (the guard applies to the full hit before it happens regardless of what charm is used). |
…to reflect it's usage for recoup
Edvinas-Smita
force-pushed
the
fix/overkill-and-MoM-EHP
branch
from
8a6efdf to
e850827
Compare
MoM with ES when there is ES bypass was not capping effective ES. MoM with life loss prevention was not accounting for the multiplied life effectiveness when reducing pools. Max hit smoothing (for conversion + armour) now uses pool reduction to effectively home in on a precise max hit.
Edvinas-Smita
force-pushed
the
fix/overkill-and-MoM-EHP
branch
from
e850827 to
6bcf4b4
Compare
Edvinas-Smita
force-pushed
the
fix/overkill-and-MoM-EHP
branch
from
6bcf4b4 to
6ec7c9f
Compare
LocalIdentity
approved these changes
Jan 27, 2025
Edvinas-Smita
added a commit
to Edvinas-Smita/PathOfBuilding-PoE2
that referenced
this pull request
Feb 4, 2025
Edvinas-Smita
added a commit
to Edvinas-Smita/PathOfBuilding-PoE2
that referenced
this pull request
Feb 4, 2025
Edvinas-Smita
added a commit
to Edvinas-Smita/PathOfBuilding-PoE2
that referenced
this pull request
Feb 4, 2025
LocalIdentity
pushed a commit
that referenced
this pull request
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542
Closes #451
Description of the problem being solved:
A previous fix for MoM EHP calculations was erroneous.
Steps taken to verify a working solution:
Before screenshot:
After screenshot: