Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong calculation for hits before death #542

Closed
3 tasks done
AndreVallestero opened this issue Jan 22, 2025 · 0 comments · Fixed by #552
Closed
3 tasks done

Wrong calculation for hits before death #542

AndreVallestero opened this issue Jan 22, 2025 · 0 comments · Fixed by #552

Comments

@AndreVallestero
Copy link

AndreVallestero commented Jan 22, 2025

Check version

  • I'm running the latest version of Path of Building and I've verified this by checking the changelog

Check for duplicates

  • I've checked for duplicate open and closed issues by using the search function of the issue tracker

Check for support

  • I've checked that the calculation is supposed to be supported. If it isn't please open a feature request instead (Red text is a feature request).

What platform are you running Path of Building on?

Windows

What is the value from the calculation in-game?

ceil(combined_hit_pool / post_mitigation_damage)

For example, if I have 2000 mana and 2667 energy shield with EB and MOM, the combined_hit_pool is 4667. If the calculated hit taken is 3568, I should survive 2 hits before death

What is the value from the calculation in Path of Building?

Image

As you can see, hits before death is 1, which breaks time before death, aswell as effective health pool, which is likely the cause for #451

The behaviour is defined here:

local function numberOfHitsToDie(DamageIn)

How to reproduce the issue

No response

Character build code

eNrtXVtz2ziyfh79Cpaq9rxYsXm_5DizJd8941skJ87kZYqWIIkJRSq82Fa29r9vN0BSIE1QlLzZ452TqRpHAtAN4AO60d24aP_vT3NfeiBR7IXBu66yK3clEozCsRdM33U_3J68sbt__7Wzf-Mms-vJQer5mKP-2vlln36RfPJA_Hddw-lKI9-N4yt3Tt51h2E0IhGJ467kxiMSjA-5vCSM5o_EhUq7UuJGU5J8zOuX_1SAz8yN3FFCogvk3U-T8DIcA-HE9WPSleauFwzD0VeSnEZhuoBGd6UHjzyyQueXN9eD2y408Jf9G99dkmiYuIkUw5933T7U6U7JmZcAieunUF6VbWXXMgxLNbp7jVQHaRQnR-4cPm5CPVwQMl4R7AoL3kTkeDIho8R7IIeRlxzO3GC0qsoR0W1a9jL1E2_hewh_0SrNEpGcPeOuyLKo8G2YuP7RzbAoa6iyvqvZjqaIEWJE4WpMhOzvvGR24AOem1aBhOfTwEvINpQ3oReHwbbd4umEPTtMfR8Eq1XZAYlJ9OAmXrlNYt7h_N4LNgft0g3cwzBejYtiN5a9ISD0QVIikdcQDMkoBO3Ak-hmg5Bw9dRTCyu88CakfcmN-pIRbNqa7fpxPGxbbmPG2zVoAAqxXclhmPotSyYr5WTYYkH4xhfUFVHBI_K0Yqc0sOML6pqo4HnArR-K0cCPL6lomrh9DyGK83pgqFI5PrtZtVJ37F1blS1LtRxdCNXNbBl7I9e_dJ-8eToHpX7rfiUBJ3SWI56r01kSgHYSERuwAIqIT7yICOlkSxcrLX8sojMtUwg6rFVhLCL0gkmTQK6GqmExH73FoufBqChtN_H8EERUXXM2gNJUfgCSh_bGvU_aEawqyMS3zTrNapqSIKtu2U5jXRAymp2C_TVwE9JOx3Omkrg5FFYszcOqNvKtwbWphjLJBkghYT1Sqq7uKk1kG6I1XHgRb5jaRnPJupmltKapQqDLu5oh25alOKpjq8JFIiDRdDmcecTngDdNqw1BDuGhu2hFS6cFz6AkdXa7Kjea5DzphsOHy-CmtT24Ma_1VcdshoKV51EQz1sCdjIQjEnFepfF_kf4Bb0PfzOyfjQP04ibgnZjH1jxVl3I1yzmcw3IOB2VFkmh8BVu1IEPfmLbjhRU0E7f34i0nyTu6OtROJ62ho1WshFFuX3DdLFABxsAacsAl2LwHTzeolfWF76GycxLrNy0ZFf4a_r6wq35F3ZItRNOS4r2PUEjolKLqrco3bqGYjAvQVfMQRHTMMFlyOnyXVURGown4C6W3DnLVndNU1dM3bLMRqp6hzRjOPzq-b4U498bNwKSrhSDuI4I_ZTJ-6jJi2zP6Dq6l8KJRMNBMdcTfdfQ5a04fgz9xPVG0lX4sLI7tF1L0w3NacDlJnyEYZthKCpuoZa40mBorioSwh6R4PuyNf9S8VYVHAfjNEId0LqOKkVdNQfpZBJLo3B-7yYXMLcR53tIY59hGsxQLfekQ98FywKWu1EaxYTl5iNx6UZfoQT4kqi7H7AYY37rzWGBiuMjN3Glceb-fARGbpCoNKQXExeqQHYnru_fg36lA12ksgmAYcATz09IdARp2CPsdZWjki8W-3s0aomfzueLMEok8oT_4Ixa5hFGWpCmAJ848QIaaoEu-35XGs7Cx_74AWu6DUM_LsKS7mJBgnGJx21EiOTmOnuEjaCdxy_S3I2h1UumCGLsDRcpPR9TDIIQGoBa2rTUnqpZpt5TFEsze6qj6nLP0HXd6umy4fQUWdGUnqo4tt6zIAVKKLrdM1XTsnqmAgLVU1XVUnqGBhZXT7cUSNdM25aBVLPVnuLIug4pqqP1dFu1e5ZjQg0K8HcMRe1Z8F_PtlWlp5u24vRUC3gjZ_gM2keBsoYl2z1V16CMii4h8DEMoFR1aLBq6D3bVMyeISuy3gPrFuo3bMfsKZphwV9Vt-2ebZgONs60ewpoAfira1oPlJoNNZqWBpmobqCdmoWfZcBCdywAQHNAF_UMB3rQ0xSQdsBFtqDXpgNoOKau9nTDUYCjZmk2dELWoLhuYIcM2zYAGAX6b2kW0qtQRLWBcU-DqqAIUALIlqxCGdvSgJkiq9AC04B-GZahaFirIQPusgzpum0hCjJgZBgmdEe1LKwE7GtEXMEWGwaMimKbhgLdNGFUTM02gY-sQrUqpGqGaQEOsq31DFPTAQJbhyYptL2aI2sWMMcGaLoN0wHQAKR12cIBgEGlAwDJAATga5gwqLYN1jYIEUZ33GjZL8-4wIMJnsCkrcTj83ydTt9f9j8MLuiHX2ZJsojf7u09Pj7uLtxkFk7IE9iPu6A09hZABBP_DdXYb5DrXh_-O5i-P_h8qP7x6ep9op6d60dOHHxVPk3PrpUn7eb2o-Ukd386_WF6PH9_fOhdD-fDq6fBxejsaXp4MDoJz-bH3vj-_ov7Jnow35wN1c9Pk_7dzccHdzq6nX65Pne_HKX9ePHlaKocHh2dn3-a6--PHh8PPgfOyd3s-zft7vrUnI4e_Teff7ueeJPr-ci7-_r5N_fb909f7r7FzsWHN_eXzsnl74M_z8LT0fDN0Se7778PDz_d_n5wkoyj6bdP369HH08fBurZofppEHvkJP3NfPN7JH-5v_4QGePHh8HRxeWV9T2KtAPl4fq7fjU_0z73w-kf43BxEz5dLGdXfzhHh79_AUjeUVD3clT32eZGzCDOvlFVgGOAYtmVvITMqY7IjO3n5ahkcgUz6wXq4dnvo8ESeaBlMi5gyUbefZqQPANU4NMVU0PALUiyz0x0mRpi8sqpISb3zzUQEzqme5jWYQJIRY_Nal6smEAx9cOEiEkq1QlMQKgoMo3CZIBXP0wUmThRiWZ6FHUMWgxR3hUmSFQymW5jWgS1VQFaCSfAEDQ4XU5QxeOHqzBheZiYf9mnNksMy1SUnJJ5fLAEO-YEfctKUD5bI7D0kCRs-eNp3nWTKCW4rE3c1Mf096nre7hkyXzqBduMC8CiKkJ9wAqWLHQXGMfb5QJ73b-4yBajrFbJG-cLVJZId9r6q6Yduv4opo3zgpGfwjwLMtssb5_v3mP9uIWIAaxxnl5hVNTzyz40iJok0IDzAKZapoQY_akf3ru-WnBnvYOpXMpX8vwHttjjdKdGKtU82TdmAXWlbxxuUyYalyRxx2CG7J2DrMR7CPoebSZ8onwCd56t3_RrpW-jMA2yIeP6kWGFndl7QVfX9_SEmhGH8DcbYq7fWcqqyKYoFJMGOu4G5JaAzVTBA5KlLP11AVP4fsdg4cVpRIT4PCu5NUzPOPFgFZnSKvd1QcYCCbch2Lijr0K4SqW2hir3CTCes8KIT31d2AxhXVz0H92lEJeixEaYcJAUDHhEaKLEUrdDZJ9ps7-GYr-O7q8necigGAEudUtFX-K7Qr8So3hdU_I8GEXERZd77om1f6nU1uJ6TfekUvAaaKiRQ6ic8boQ-hD40PWZEJssf2tUMnoejyLp1al2L2hS6V6wvSpH6pIWZwmvCwGcqCMa7RLCsCryIjlhLKpCkqf-VOLdSwAVlUWBP0vYcN3MNHfObIV2nvIT6e7Qm3r-9YSGrPn5ziVvuWCWOXP2CqbjmpnlvC4lcBlG5CiNaED3uRqoyd1aEdxgCA38rspyWUp-ZUtEGPrj8DEoNlrFy0W15NYonQdTEqR092CFEZf4U4S76LdfB9TZ4qcqwMrlbCnEJd7c-g3JUhhIWcZ_cJqa6_HItpZwZ4nDg0vdbhkpsV1BwW9kvTr7f74gSRqLLX-Wv607mpGXJDNPel1AsFM7AwJqtVFvVcptC0yFDQ8Qy5K4vJ8arHvgu_FiRuZLbkSKtC01F8dzhT6X-J-coG2UOL8DvkKBT95WhZc4P4-kPbxgHf1hlgYeFGAb32IbY1Vma-vijGDIlQRkTLnx8KyypCzvdcZ2xn3453qyBqza0lvDdulOA2_ikTHjU3atsiwpz_up3-hZX9wCIXHJmVilbinaJb78GASuVKS_spV4vkC3j4zZmU3xSlwut72XFZE5GXuJW12IKxmvFCW89bUeIyy1vTCn0ZhEYRqfBwk9781NpDxLyvNemw6MF57IVy80X1HmBU5owaPshnLJP9VcceKvvLE-21h--c31jGFpRzlLe6W7yZfs2N76zeSs4Mv3kjNG9VvJReYrs_DYmVCxdcfyt99yyM-ccgZvnvRiUc0-QlF6xIcd4sGPlIiWOA8WaUIrf9ede_HoTzwYixfQ6cEienf--OTk-PD2_ONxduKVJ6Fw_Bmk83saPKX_ru4zDAkNqklxeh-zj--6Hz3ySBtyBLh4foz98n13EZPiyCk9wJO13EfbTMyNljrzitvs9bxWBcScjp9IlEB_79xoFHlE2K4if02jWIV4fwZPCIu44WVxMSN2GwODWOzmjgApei9fzAWvygu7g5kNtOfzhesLa85y1yCR4DktmNlgbo_w5HbzkOOpLlaqAZfRKI3c0bJhvLOrJGIe9Pa9iAHLFBOze_Qi6iy3AVV6gV-IKssVkx-RkSvsO8sUExeXwcKAvh5Rz6Uo1cDpKgzoJAeh6Xs-Xv0QjuyxT4oiYobXyYxE2TFyEadL0FF5kUbBYYc_hXy4Eg1Y0au0AoQwT0zKbowK-oB5DUKTXZ8USbvXLLLli42C8eDLiFmxq0BCDLN7RQ3DkN2oEwwBy23oSX6rUNCJLLtBUKgO7j-EXnaoQyAylWJNSoPuI7yUDb0t93I21etzL-d44rvxV-F4Z7li8g-Jh9ZPDRdmwbRigoL1Mg4oXy_jgJeJ5ltTD6qmyIp20GyEFNeeaonz3CbZz25Dbc2B3dnamjzbK9-Smi4AR2SCm8qNK0BRpkE4kjTIt8BfyIo2q16LrHq3ES-2Ftb2dGOOTLqz5yGaFAArsoYRLOZnDeZiO07FndAz4vr46lDov4zhs2cwXsIMr7WnCzcY5-yu64z01Ti0RC9MYuBJb-Ud4e35l2IYkPmyhpG4Xft7uVtH7-uho5XdMhwmEcZdvofh_A_wzgxZ2ZUt23ZM-F9n6dmFC8XMblmABX7kwTBGdPrl1WLJT--6bzTZ2rUU23AUWVPZpeV96t5mF0Dwc3H_Q8wujQl7n-eOuIswoBQMKOZoAhf-MseA-sVvpUF_cNxhdpB0EIWPnbMQHNYxhhC-djKr4K1kmJ1sE5PZOW8l1elQlrSvbyVN6WSXTyBL7tDUAflGv4Bn43sjEIS3ktxRjb9hUIttTEhZBRIMtlSqoLOjalISSnM2WSVchjo7ivU3TMRb4hIzmFCJQLpG01cBEC4TvXjwwQduMCVShH_fdeVdo5uBkfn5whLq2hLa2hL5HXEatSiPhlozGoM0INIxWDUdfGYMY73SHQBUwls3BXhDRglvRZZ5wKmZI7HZ3tkxzWcYqzpfHD1afGyhRCcdhEEaA-oqUmOU2Pe9KU7Gjm7z1HRPgr5-QdjaIaHr_YpGpKGEIR4zrWbMjt2pT6Q7-n5h5xoWJGk4IoskIplsvZUUUy1LjCEYQRCl0ghqRnkAkV2nD5CTGNKlJdj90g0-4AIDII1hkZB0i6fIBltEMYMmSzsqHcs8FoDjBGLUTKNqtTOlNEcaGTg8PQvPSDT-0imz_gtMo4YSpnii6TUT7TCMonRBUbiL3EVnCJgvSPQ_oPPj_42l31y8xrlS3IouVzW3YZfmoVWeh9k90LfSUBpSTfSW3XOQ8HOWcISvBSUshZu3Dj9v1c4_YKRnbpD88x8RFPwnqAuqpPEJEV4_C4rV6vIdU-UVFno3nR3dwrRMLmApeKaUdhS9tuYdTf5vWDb-HbOroYQlnn9Gzfw7QhBPACwSxTBZ5vfw9dQPH0hcnWemUppniirQd5BR0neVlb9sFmglzVAxGaznk0ORMe2IPCUEO_HKrQGzDnB3zp6akPDS1xgUOXtnYiydRO4SV4RZiODnEu-o1YHQrNJAGCKBb5Ru3eBHSWkr3WVzL3_WJlPzit3SFrTqbEGlPLI7ilNvHKrqTylvknKreZW5gPnRGbiPM7z2f0D8pEMDOtLQD9lM4OdWWbCV8pQpr-oon1L-Kpo0icK5xIJBncwYqQhy_fzK06ujXpp2rMFZyESaunjDvkOnjyblz4lJt7MwCmJpzKylv75xYdcM-xkMexjBKLvjuHOKkPbnqQ_2RMlwNflFv6IWlJLpyZjjvQ_m0E7CNEBxNmpWcaW0itfL8uvW3k4Doui_3URePAdVPpIGaFy3xnSHgeGCA3bsU_0J03WFSoyGzDNAlZLbR8_uM6WbY1uVpNeNrSLXgHvqgs91GrkxmMHuYjGjPapCqxq8SqpCq8r1i4ZmPVtxFE2AqKK38FbK40EXI8gYe-Ak_bf7w0olpHTZPz0_7JwHD_hM1tQF7yH3TsCTCEimjkEpJDNwmdGk4cfLWVkn_GJilwfuA6L4OCPUsZTuYRmZEwnD1KjaL2BsYknddWSJhcRiWNCCOJ2D9tdlrFmR5WI9gBFKY9I5TKMIRMtfgnMa8wU6illyp7M4eMW0yQv_uHVaUetgPkjv7_GNeOkWWNGHm9C-oosrXU5znE9C38OFrWQJagKT3KgE7bJlOpZsgI_yxq-S_hxehcILCr4R3VV-B30woCgMAZBjH08SnwcoikDQwZ3zWJJ3lRVTcHizqn_ktNbq8O6zW-1JGW8q9CW8b_DHKjycKCQqg65uCrpuaKwCCrq2a9RMa3tD2I1y8GWOx6HyQcAADIxKhPf4VjObgo48fyDieh3il8sY18xCw6M1gac6UAYrfk0l8ikMfJatlBE93kLDBvS0yL9JIdf2sOJSf7g6f_8BFrJZGCePEUZ7O7duktCY7yC8J1VXTlHLwRtb5bVlTezmKiyiNvRj2dNGLSd0tXdUFjahD5mWbGuTiuwlZ27gY44wcxJoNlCU-WS-BBn_xxa6WuTNWuT7yXewOPP16ciLx6BtmOl76EUjtH2bw2e2Uj8CPOicF12R8R2zxs7Q15vQ6EpBUhZrTXDbSrpf4uN6IKhl-FF9SpryfMhAIRw_JZFbpP5fD9uWlqFVO7C3oIOPYUqCTsZQtnTqfied_vcUFEiNT2NXXdU2-xg7hvxs8Ay5BSEdEtUqDQkt-lcZErt25RxF3jwMPLxawCvzmxAvvi_Lury6i9Vir8EsI4-qPB3TGvLjctRW9IIJ8E1-pJKvcwQvXeLHCUY5bh890AnXUQBTYW1AxeK9F6PqbOvlVXoV44B1Gj09xaa7OvRsGHw16uIqhvE8tqYqgmCLIw6lYTAvbwyzhEqN-Rlpo79dURPfTQGq02VEmuIDpik0FMGJtdfFBxRTrtve23H0ukCb83xJsoXBBLkahZXXNObnRMCfB6qZCCchrFhLmAbEjfznU8By-ClglqeAIxif_ngcS3Q8FXMV6szNhjDbdYUZ4tjPTwKookG38xFeHfzFiMkrD9n9qECqWneG49IDQfMxJOGKzgPYRnnJc0R-oV1eCw295jzATo3UNp8RsGvOCGS7p0NoZzBNZtALWK7B-abb9Vqp3nKw0fr_EwH7AToB39kVH98qP8ELRgJ9vvnm_sPgAg-isbtDbAt29bJz0VgRAatGUlYk6joStqpzFMpaEmZqcxTWOgpmx2grErkdBd-sYsYwd-x8DOWLJ7Dpa-k57W_kkfhSlsTzbgWFytWpNdaJL_BX6mRJG9SZjRhXqao2VZq99c1Xyj3_3bJStE-5Xjptp5U0fMQfPGk9iLjclbomN3WNPXfO92z1AHrbjoXjpZTfqSj611Zs1K36xwub0m5aq3V11CBCf5CgDEmWtAEmZwT8JH64zfUohgmndUqrJLspiedn3THoNjw7e0ff18gemac_PPJIU_DHZ-nPDMvFzWa87yzRZ9DLv22z14b4eDLZLXzoMy-RspPO2Y8sUT2La9v8-U8fiviDCl_xx3MMUsx-wnfdL_dkiNSiwIBit0jDYOJNsyO_7Et26JfSFylS4iU-watp9Hn38urA3yb9lpI46Y8S9TBKif8RzDWyzIPTtx4YZ_HqVqomr9suz3Gpq0G7oi_LY8TlIwnAwz2MlouEY185BFJrHtRVgMNE47zo8A_IiEayu9J9GPrEDbKDzzV0eO2WPUI-TOnrmmspiq5QsMQ92aHOcr9k-jbxUxk0zegrdfA8PxfRiBA94U5fZsM5WdvfG98dkRmY5yTKqAklYtM4v25syfIagtLPYOVk64iKkEF-ubi43iyvVjFRhdxPWedkhpiGvVNO_Zpnt6jFdUDKFk3DCMkWZNS4X1HYurj8vPhd7vwwOO3aIW7YDIk_4eo1WvSxOm5G64G7QQWak2ltqTauj86uKqS67LQYiLYtjLlHSgFMekes9TzJQo9gB3wNSBxX55kqt2jo5qBAStveDUchvaWy2fzPfk0x9H3quPD6YA1lbkMVNam2s46m_BuOGyuDKpm2rr7i8mshcU0idzjD1xLqAdzfK1ZidkuIfvu1s7934yaz6wm9sgTzXv218y9H7BHI

Screenshots

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant