Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the ingestion of physical messages containing multiple logical messages #7129

Merged
merged 3 commits into from
Jul 31, 2024
Merged

Fixes the ingestion of physical messages containing multiple logical messages #7129

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a248bf6
The IncomingPipelineMetricTags add a new tag only when the key is not…
saratry Jul 30, 2024
5d00fd0
Remove acceptance test for now
mauroservienti Jul 31, 2024
d1f111c
Add failing test
mauroservienti Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/NServiceBus.Core/Pipeline/Incoming/IncomingPipelineMetricTags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,15 @@ public sealed class IncomingPipelineMetricTags
Dictionary<string, KeyValuePair<string, object?>>? tags;

/// <summary>
/// Adds the specified tag and value to the collection.
/// Adds the specified tag and value to the collection if not already present.
/// </summary>
/// <param name="tagKey">The tag to add.</param>
/// <param name="value">The value assigned to the tag.</param>
public void Add(string tagKey, object value)
{
tags ??= [];
tags.Add(tagKey, new(tagKey, value));
// We are using tryAdd to mitigate multiple logical messages transmitted in a single physical message
tags.TryAdd(tagKey, new(tagKey, value));
}

/// <summary>
Expand Down