Fixes the ingestion of physical messages containing multiple logical messages #7129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… yet in the collection for dealing with the use case of a payload containing multiple logical messages.
lailabougria
changed the title
...cceptanceTests/Core/OpenTelemetry/Metrics/When_payload_contains_multiple_logical_messages.cs
Outdated
Show resolved
Hide resolved
mauroservienti
approved these changes
Jul 31, 2024
mauroservienti
added a commit
that referenced
this pull request
Jul 31, 2024
…messages (#7129) * The IncomingPipelineMetricTags add a new tag only when the key is not yet in the collection for dealing with the use case of a payload containing multiple logical messages. * Remove acceptance test for now * Add failing test --------- Co-authored-by: sara pellegrini <[email protected]> Co-authored-by: Mauro Servienti <[email protected]>
mauroservienti
added a commit
that referenced
this pull request
Jul 31, 2024
…messages (#7129) (#7130) * The IncomingPipelineMetricTags add a new tag only when the key is not yet in the collection for dealing with the use case of a payload containing multiple logical messages. * Remove acceptance test for now * Add failing test --------- Co-authored-by: Laila Bougria <[email protected]> Co-authored-by: sara pellegrini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to Particular/ServiceControl#4333
Previous versions of NServiceBus supported sending multiple logical messages per physical message. This resulted in an issue when collecting metric tags, which is resolved in this PR.
This issue also surfaced in ServiceControl when using the NServiceBus.Metrics.ServiceControl package as it batches multiple logical messages in the same physical message.