Fix Yii debugger issues in test run #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexander-schranz Success! 🍏 only a minor thing on PHP 8.4, not related to debugging
|
|
Thx for the pull request, the default yii app skeleton seems also not have this enabled, are we sure this is expected now: Maybe @samdark or @vjik can confirm what in the app template should be changed? To avoid this errors: https://github.com/PHP-CMSIG/search/actions/runs/12847334123/job/35823522845 |
alexander-schranz
added
DX
|
We also faced this problem after last changes in Yii Debug. I think, we will fix it soon. |
|
@vjik thx for the fast feedback. Let us know if there is a fix available or change required on our app example. |
|
Hello @alexander-schranz ! We made changes in Yii Debug API. Can you run tests with latest version of |
alexander-schranz
force-pushed
the
patch-2
branch
from
9286400 to
9962027
Compare
|
Looks good. The PHP 8.4 is related to Roave/infection-static-analysis-plugin#499 if somebody know how to fix that issues let me know. |
alexander-schranz
changed the title
|
@szepeviktor @vjik thank you! |
alexander-schranz
added a commit
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in #478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-elasticsearch-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-opensearch-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-solr-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-redisearch-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-loupe-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-meilisearch-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-typesense-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-algolia-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-memory-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-read-write-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-multi-adapter
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-symfony-bundle
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-spiral-bridge
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-laravel-package
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-mezzio-module
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
alexander-schranz
added a commit
to PHP-CMSIG/seal-yii-module
that referenced
this pull request
Jan 23, 2025
PHP 8.4 is not yet supported in infection plugin by @Roave as we found out in PHP-CMSIG/search#478 @szepeviktor. So we will remove the unneeded infection part of the example to make the CI green again. Else I tried where possible to update the composer.json to match current state of https://github.com/yiisoft/app with changes by @vjik and the yii team. This PR will update all deps also to the latest version. Co-authored-by: Viktor Szépe <[email protected]> Co-authored-by: Sergei Predvoditelev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476