Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better explanation for constants #167

Merged
merged 2 commits into from
Apr 19, 2024
Merged

better explanation for constants #167

merged 2 commits into from
Apr 19, 2024

Conversation

ozgunozerk
Copy link
Collaborator

@ozgunozerk ozgunozerk commented Apr 18, 2024

Fixes #143

I've confused myself with v0.1 and main branch, and also introduced fixes to main with the other PR #151.

This one keeps the scope only for v0.1, will be easier to inspect for audit purposes.

After we merge v0.1 into main, I'll update the other PR #151 and then we can merge it, for now, I'll keep that one open.

This PR:

  • adds explanation to SS58 prefix (42)
  • merges some of the unnecessarily separated parameter_types! blocks
  • and fixes some typos

@ozgunozerk ozgunozerk requested review from KitHat and 4meta5 April 18, 2024 13:54
@ozgunozerk ozgunozerk enabled auto-merge (squash) April 18, 2024 13:57
@ozgunozerk ozgunozerk merged commit 46a58f2 into v0.1 Apr 19, 2024
1 check passed
@ozgunozerk ozgunozerk deleted the constant-explanations branch April 19, 2024 07:52
ozgunozerk added a commit that referenced this pull request Apr 29, 2024
* Add zombienet config to release (#158)

* Cleanup docs for the release (#160)

* Updated documentation to version 1.7.0
* Updated broken links

* updated docs to v1.10 (#166)

* updated dependencies to v1.10.0 (#165)

* Fixed weights for non-XCM related pallets (#149)

* add remove proxies to filter (#146)

* Fix weights for XCM and Message Queue.  (#153)

* Fix for PriceForSiblingDelivery (#156)

* Fix the FeeManager setting (#159)

* better explanation for constants (#167)

* better explanation for constants

* Removed polkadot launch (#169)

* Removed warnings about experimental code. (#170)

* Attached audit.

* toml sort

* changelog and version bump (#174)

* changelog and version bump

* cargo fmt fix

---------

Co-authored-by: Nikita Khateev <[email protected]>
Co-authored-by: Amar Singh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants