🐞 [Bug]: Port audit findings for generic template to evm template

[ozgunozerk]

templates

• Generic Runtime Template
• Evm Template

What happened?

Below is the recap of the audit findings and the related issues & PRs:

• 3.2.1 XCM delivery fees (no issue is submitted at that time due to visibility) → https://github.com/OpenZeppelin/polkadot-runtime-templates/pull/159/files

  • tracking in 🏗️ [Core Feature]: impl FeeManager for evm-template to match generic-template #223

• 3.2.2 no xcm delivery fees 🐞 [Bug]: 3.2.2 No XCM delivery fees configured for sibling parachain messages #154→ Fix for PriceForSiblingDelivery #156

• 3.2.3 incorrect weights for xcm and message queue 🐞 [Bug]: 3.2.3 Incorrect weights for pallet-xcm and pallet-message-queue #135 → Fix weights for XCM and Message Queue.  #153

• 3.2.4 insufficient benchmarking 🐞 [Bug]: 3.2.4 Fix insufficient benchmarking for runtime pallets #138 → Fixed weights for non-XCM related pallets #149

• 4.1 filtering 🎁 [Feature Request]: 4.1 Implement stringent filtering for proxy calls #141 → [v0.1] Add remove_proxies to filtered calls #146

• 4.2 benchmarking 🎁 [Feature Request]: 4.2 Adhere to benchmarking best practices standard to the polkadot #142

• 4.3 improve docs for runtime parameters 🎁 [Feature Request]: 4.3 Improve documentation of runtime parameters #143 → better explanation for constants #167

  • also documented new stuff in impl fp_rpc::EthereumRuntimeRPCApi<Block> for Runtime
  • removed const MAX_POV_SIZE declaration, since it is available to import from polkadot-sdk

• 4.4 remove link to archived repo 🎁 [Feature Request]: 4.4 Remove references to archived repositories #144 → [v0.1] Add remove_proxies to filtered calls #146

Expected behavior

We should port these fixes to our evm template as well.

Contribution Guidelines

• I agree to follow this project's Contribution Guidelines

[ozgunozerk]

The first wave of fixes are in: #236

There will be follow-up PRs to fully close this issue.

[ggonzalez94]

@ozgunozerk I'm marking this as closed since I don't know of any finding from the generic templates that we haven't ported to the evm. Feel free to re-open if I missed something