-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(MainPipe): fix s1_way_en
generate logic when ecc inject occur
#4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1_way_en
generate logic when ecc inject occur
[Generated by IPC robot]
master branch:
|
linjuanZ
requested changes
Feb 19, 2025
[Generated by IPC robot]
master branch:
|
linjuanZ
approved these changes
Feb 20, 2025
ChrisYzcc
pushed a commit
to ChrisYzcc/XiangShan
that referenced
this pull request
Feb 22, 2025
…penXiangShan#4285) * When inject tag ecc error `io.pseudo_error.valid == 1` and mainpipe request valid (for example `io.miss_req.valid == 1` ``` val s1_need_replacement = s1_req.miss && !s1_tag_match val s1_need_eviction = s1_req.miss && !s1_tag_match && s1_repl_coh.state =/= ClientStates.Nothing val s1_way_en = Mux(s1_need_replacement, s1_repl_way_en, s1_tag_match_way) ``` when generate `s1_way_en`, `s1_tag_match == 0` cause inject tag ecc error, so `s1_need_replacement == 1`, but may be target cacheline already in dcache (for example `prefetch.w` miss), finally there is 2 same paddr cacheline in dcache, obviously this is illegal. * Determine whether it is a pseudo error. If it's pseudo error, use no-toggled-tag (which no toggled by cacheCtrl) for generate `s1_way_en`, otherwise use toggled-tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io.pseudo_error.valid == 1
and mainpipe request valid (for exampleio.miss_req.valid == 1
when generate
s1_way_en
,s1_tag_match == 0
cause inject tag ecc error, sos1_need_replacement == 1
, but may be target cacheline already in dcache (for exampleprefetch.w
miss), finally there is 2 same paddr cacheline in dcache, obviously this is illegal.s1_way_en
, otherwise use toggled-tag