Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent class potential #1093

Closed
5 tasks
l-emele opened this issue Mar 31, 2022 · 4 comments · Fixed by #1102
Closed
5 tasks

Add parent class potential #1093

l-emele opened this issue Mar 31, 2022 · 4 comments · Fixed by #1102
Assignees
Labels
[A] new term Including new term(s) in the ontology OEKG important for knowledge graph generation oeo-physical changes the oeo-physical module ready for implementation stale already discussed issues that haven't got worked on for a while

Comments

@l-emele
Copy link
Contributor

l-emele commented Mar 31, 2022

Description of the issue

From today's OEKG meeting:

  • add parent class potential for stock potential and flow potential
  • add axiom between potential and spatial region

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [A] new term Including new term(s) in the ontology To do Issues that haven't got discussed yet labels Mar 31, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Mar 31, 2022

The existing classes flow potential and stock potential are defined as:

  • A flow potential is a quantity value that describes the upper limit of an input or output of a process in a spatial region of reference per unit time.
  • A stock potential is a quantity value that describes the upper limit of a stock of a source or sink in a spatial region of reference.

Thus I suggest: A potential is a quantity value that describes some upper limit in a spatial region of reference.

@l-emele l-emele added the oeo-physical changes the oeo-physical module label Mar 31, 2022
@l-emele l-emele added this to the oeo-release-1.10.0 milestone Mar 31, 2022
@stap-m
Copy link
Contributor

stap-m commented Apr 1, 2022

We can use potential 'is about' some 'spatial region'.

@jannahastings
Copy link
Contributor

@l-emele , @stap-m , we have a new team member @markus-rothkoetter and I wonder if we could assign the implementation of this issue to him as a first issue with your support ?

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Apr 1, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Apr 1, 2022

I am fine with that and just assigned this issue to @markus-rothkoetter. I also think, that this issue is ready for implementation, as we discussed this issue in yesterday's OEKG meeting and the only thing left was a precise formulation of the definition, where I already got a thumbs up now.

@stap-m stap-m added the OEKG important for knowledge graph generation label Apr 5, 2022
@stale stale bot added the stale already discussed issues that haven't got worked on for a while label Apr 19, 2022
markus-rothkoetter added a commit that referenced this issue May 3, 2022
…ential-as-parent-class

add potential as parent class #1093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology OEKG important for knowledge graph generation oeo-physical changes the oeo-physical module ready for implementation stale already discussed issues that haven't got worked on for a while
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants