Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent class power capacity #1092

Closed
5 tasks
l-emele opened this issue Mar 31, 2022 · 13 comments · Fixed by #1155
Closed
5 tasks

Add parent class power capacity #1092

l-emele opened this issue Mar 31, 2022 · 13 comments · Fixed by #1155
Assignees
Labels
[A] new term Including new term(s) in the ontology OEKG important for knowledge graph generation oeo-physical changes the oeo-physical module

Comments

@l-emele
Copy link
Contributor

l-emele commented Mar 31, 2022

Description of the issue

From today's OEKG meeting:

Create a parent class (e.g. power capacity) for the capacity classes

Ideas of solution

If you already have ideas for the solution describe them here

Workflow checklist

  • I discussed the issue with someone else than me before working on a solution
  • I already read the latest version of the workflow for this repository
  • The goal of this ontology is clear to me

I am aware that

  • every entry in the ontology should have a definition
  • classes should arise from concepts rather than from words
@l-emele l-emele added [A] new term Including new term(s) in the ontology oeo-physical changes the oeo-physical module To do Issues that haven't got discussed yet labels Mar 31, 2022
@l-emele l-emele added this to the oeo-release-1.10.0 milestone Mar 31, 2022
@l-emele l-emele added oeo-physical changes the oeo-physical module and removed oeo-physical changes the oeo-physical module labels Mar 31, 2022
@l-emele l-emele changed the title Your title should make sense if said after "The issue is <your issue title>" Add parent class power capacity Mar 31, 2022
@stap-m
Copy link
Contributor

stap-m commented Apr 1, 2022

Currently, the parent class is power value with a very broad def: A power value is a quantity value that has a power unit as unit. According to this def, a flow potential would also be a subclass. Thus, it makes sense to find a more specific parent class power capacity.

@stap-m
Copy link
Contributor

stap-m commented Apr 1, 2022

Both potential and capacity are kinds of maximum values... I just had the idea of creating a common parent class? A maximum value is the upper limit of an artificial object or process to contain, transform, ... something ?
We could add capacity and potential as alternative terms.

power capacity could still be a subclass: power capacity is a maximum value of a generator or power generating unit to generate power.

@l-emele
Copy link
Contributor Author

l-emele commented Apr 1, 2022

Hm, I am ambiguous whether I like this idea or not. In your idea, the existing classes declared net capacity, block size and nameplate capacity then aren't any longer subclasses of power value (A power value is a quantity value that has a power unit as unit.)

However, we might solve this by making 'power value' 'equivalent to' 'quantity value' and ('has some power value'). If we do so, we probably should also for consistency make the other basic dimension values (length value, energy amount value etc.) equivalent classes.

@github-actions github-actions bot removed the To do Issues that haven't got discussed yet label Apr 1, 2022
@l-emele
Copy link
Contributor Author

l-emele commented Apr 1, 2022

Currently, the parent class is power value with a very broad def: A power value is a quantity value that has a power unit as unit. According to this def, a flow potential would also be a subclass. Thus, it makes sense to find a more specific parent class power capacity.

I didn't see that comment, when I was writing my last comment. flow potential can have a power unit as unit, but not necessarily. It can also be e.g. W/m² in the case of a solar potential or m³/s in case of some fluid flow.

@jannahastings
Copy link
Contributor

@l-emele , @stap-m We have a new team member @stage1407 , would it be possible for him to work on the implementation of this issue under your guidance?

@stap-m stap-m added the OEKG important for knowledge graph generation label Apr 5, 2022
@stap-m
Copy link
Contributor

stap-m commented Apr 11, 2022

I was just wondering, what parent class makes most sense for our use cases. power value is of course not wrong, but is it a useful classification?

flow potential can have a power unit as unit, but not necessarily.

The case above is a good example, that another classification might be useful.
I think a parent class maximum value( or even broader: threshold ?) is a reasonable grouping because it's independent from the unit. We could have power value as an equivalent class.
But if we have good reasons why power value should stay parent class, I'm also open to it.

@l-emele
Copy link
Contributor Author

l-emele commented Apr 25, 2022

We could have power value as an equivalent class.

Not every power value is a maximum value. But probably you mean something like power capacity EquivalentTo maximum value and power value or power capacity EquivalentTo maximum value and (has unit some power unit). Right?

@stap-m
Copy link
Contributor

stap-m commented Apr 25, 2022

Not every power value is a maximum value.

Of course not. Sorry for not being specific enough. I meant something like
'power value' 'equivalent to' some ('quantity value' and 'has unit' some 'power unit')

@l-emele
Copy link
Contributor Author

l-emele commented Apr 25, 2022

Ok, I see and agree to this proposal. The same principle holds probably true for other basic quantity value subclasses like length value which could also be defined as 'length value' 'equivalent to' some ('quantity value' and 'has unit' some 'length unit'). But I am fine with making only those classes equivalent classes where necessary, like power value in this case.

@stap-m
Copy link
Contributor

stap-m commented Apr 25, 2022

So what about my maximum valueidea? A maximum value is the upper limit of an artificial object or process to contain or transform another entity.

@l-emele
Copy link
Contributor Author

l-emele commented Apr 25, 2022

Small extension: A maximum value is a quantity value that represents the upper limit of an artificial object or process to contain or transform another entity.

@stap-m
Copy link
Contributor

stap-m commented May 2, 2022

@l-emele
Copy link
Contributor Author

l-emele commented May 17, 2022

So I think, we have an agreement on:

  • A maximum value is a quantity value that represents the upper limit of an artificial object or process to contain or transform another entity.
  • A power capacity is a maximum value of a generator or power generating unit to generate power.
  • Make the declared net capacity, nameplate capacity and power rating subclasses of power capacity.
  • Make potential a subclass of maximum value: A potential is a maximum value that describes some upper limit in a spatial region of reference.
  • Make power value an equivalent class: 'power value' 'equivalent to' some ('quantity value' and 'has unit' some 'power unit')

I'll implement.

l-emele added a commit that referenced this issue May 17, 2022
…1092

Add classes:
* `maximum value`: _A maximum value is a quantity value that represents the upper limit of an artificial object or process to contain or transform another entity._
* `power capacity`: _A power capacity is a maximum value of a generator or power generating unit to generate power._

Move classes:
* Make `declared net capacity`, `nameplate capacity` and `power rating` subclasses of `power capacity`.
* Make `potential` a subclass of `maximum value`.

Make `power value` an equivalent class.

Closes #1092
l-emele added a commit that referenced this issue May 17, 2022
Also move existing entries in the CHANGLOG.md into the right section.
l-emele added a commit that referenced this issue May 24, 2022
…apacity

Add `maximum value` and `power capacity` and change further classes #1092
@chrwm chrwm mentioned this issue Aug 24, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[A] new term Including new term(s) in the ontology OEKG important for knowledge graph generation oeo-physical changes the oeo-physical module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants