Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macro params stringifying incorrectly #800

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix macro params stringifying incorrectly #800

merged 1 commit into from
Oct 13, 2022

Conversation

out-of-phaze
Copy link
Contributor

Properly escapes strings inside stringified macro arguments.
Fixes #799.

@Hinaichigo
Copy link
Contributor

Hinaichigo commented Sep 21, 2022 •
edited
Loading

It seems that #700 persists even with this change. The preprocessor output is the same as well.

@out-of-phaze
Copy link
Contributor Author

It seems that #700 persists even with this change. The preprocessor output is the same as well.

This isn't a fix for #700.

@wixoaGit wixoaGit merged commit db0a736 into OpenDreamProject:master Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wixoaGit wixoaGit wixoaGit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro parameters with quotes in them don't stringify properly
3 participants
@out-of-phaze @Hinaichigo @wixoaGit