Overlays on a different plane are KEEP_APART
#2244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overlays/Underlays on a different plane than their parent atom are treated as having the
KEEP_APARTflag.Fixes overlay lights on /tg/ from just applying a bright image. They still don't work, the plane they're rendered onto isn't having any effect. /tg/'s documentation implies that the plane should render onto the game plane, though the game plane is much higher than the overlay lighting plane so I have no idea how that's supposed to be the case.
The lighting plane is supposed to be masked by the overlay lighting plane, which would produce an effect. But the plane's filters don't seem to be applying.