Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsonschema: Output row for an array even if items property is missing #57

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Bjwebb
Copy link
Member

@Bjwebb Bjwebb commented Oct 13, 2023

#56

@Bjwebb Bjwebb requested a review from a user October 13, 2023 18:26
@Bjwebb Bjwebb force-pushed the 56-array-row-missing branch from 2a1017e to fce414b Compare October 17, 2023 19:35
ghost
ghost previously approved these changes Oct 18, 2023
@ghost
Copy link

ghost commented Oct 18, 2023

If it was possible to add a test that would be good, but I see it tested in the issue linked.

@Bjwebb Bjwebb force-pushed the 56-array-row-missing branch from fce414b to 3f4c306 Compare October 19, 2023 13:38
@Bjwebb Bjwebb requested a review from a user October 19, 2023 13:41
@Bjwebb
Copy link
Member Author

Bjwebb commented Oct 19, 2023

@odscjames I've added a test (and that's the only change).

@Bjwebb Bjwebb merged commit 1ebf6a4 into main Oct 23, 2023
@Bjwebb Bjwebb deleted the 56-array-row-missing branch October 23, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant