Directive reports incorrect type when type keyword is nested under a oneOf

[duncandewhurst]

I'm trying to add a jsonschema directive for the Record definition from the OCDS record package schema. However, the schema table incorrectly reports the type of releases as object when it should be array:

I think that's because the jsonschema directive defaults to object when there's no type keyword at the top-level of a property and the type keyword for releases is nested (and repeated) under a oneOf:

{
          "title": "Releases",
          "description": "All the releases about the contracting (or planning) process at the time of the record's publication. The releases must be sorted in date order, from oldest to newest.",
          "oneOf": [
            {
              "title": "Linked releases",
              "description": "A list of references to releases.",
              "type": "array",
              "items": {
                "$ref": "#/definitions/LinkedRelease"
              },
              "minItems": 1
            },
            {
              "title": "Embedded releases",
              "description": "A list of releases, with all the data.",
              "type": "array",
              "items": {
                "$ref": "https://standard.open-contracting.org/schema/1__1__5/release-schema.json"
              },
              "minItems": 1
            }
          ]
        }

I tried factoring the schema to move the type keyword to the top level of the releases property, but that causes the releases row to disappear altogether:

{
          "title": "Releases",
          "description": "All the releases about the contracting (or planning) process at the time of the record's publication. The releases must be sorted in date order, from oldest to newest.",
          "type": "array",
          "oneOf": [
            {
              "title": "Linked releases",
              "description": "A list of references to releases.",
              "items": {
                "$ref": "#/definitions/LinkedRelease"
              },
              "minItems": 1
            },
            {
              "title": "Embedded releases",
              "description": "A list of releases, with all the data.",
              "items": {
                "$ref": "https://standard.open-contracting.org/schema/1__1__5/release-schema.json"
              },
              "minItems": 1
            }
          ]
        }

[Bjwebb]

There seem to be a few things going on here:

1. This directive doesn't support oneOfs
2. The directive assumes that a field is an object if its type is missing (although I think we rely on this elsewhere)
3. A row for an array is only written out if it has an items property

Number 3 is easiest to fix, and will behave as you want if you do factor the schema. Does that work for you?

[jpmckinney]

Yes, we can factor the schema in this case.

[duncandewhurst]

Works for me!

[Bjwebb]

I've made a commit to do this. Could you give it a try by pip installing from this repo, e.g. pip install git+https://github.com/OpenDataServices/sphinxcontrib-opendataservices-jsonschema.git@56-array-row-missing#egg=sphinxcontrib-opendataservices-jsonschema

I'll write some tests, and get this ready for release.

[duncandewhurst]

Looks good to me. Thanks!

[Bjwebb]

This is now released in 0.6.1