-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCDS: Cove reports duplication when an array of strings has more than 1 item #1246
Comments
Actually, this happens with any object that doesn't have the id field. |
Bjwebb
added a commit
to OpenDataServices/lib-cove
that referenced
this issue
Nov 21, 2019
Bjwebb
added a commit
to OpenDataServices/lib-cove
that referenced
this issue
Nov 21, 2019
Bjwebb
added a commit
to OpenDataServices/lib-cove
that referenced
this issue
Nov 26, 2019
OpenDataServices/cove#1246 Previous attempt to fix this used uniq() instead of not uniq(), so always got the errors incorrect — reporting duplicates when there are none, and not reporting when there are.
Here's a text copy of the JSON you shared (yours seems to be an image):
|
Bjwebb
added a commit
that referenced
this issue
Nov 26, 2019
ghost
mentioned this issue
Nov 26, 2019
Bjwebb
added a commit
that referenced
this issue
Nov 26, 2019
This should be fixed now on the live CoVE instance https://standard.open-contracting.org/review/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We hadnt noticed this yet because all of the string arrays in the schema currently doesn't have the property
"uniqueItems": true
, but the coveredBy extension has it and when the field is populated with more than one string, cove reports it as a duplication:Minimal example:
The text was updated successfully, but these errors were encountered: