Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCDS: Cove reports duplication when an array of strings has more than 1 item #1246

Closed
yolile opened this issue Nov 12, 2019 · 4 comments
Closed

Comments

@yolile
Copy link
Collaborator

yolile commented Nov 12, 2019

We hadnt noticed this yet because all of the string arrays in the schema currently doesn't have the property "uniqueItems": true, but the coveredBy extension has it and when the field is populated with more than one string, cove reports it as a duplication:

Minimal example:
image

image

@yolile
Copy link
Collaborator Author

yolile commented Nov 13, 2019

Actually, this happens with any object that doesn't have the id field.

@Bjwebb
Copy link
Member

Bjwebb commented Nov 26, 2019

Bjwebb added a commit to OpenDataServices/lib-cove that referenced this issue Nov 26, 2019
OpenDataServices/cove#1246

Previous attempt to fix this used uniq() instead of not uniq(), so
always got the errors incorrect — reporting duplicates when there are
none, and not reporting when there are.
@Bjwebb
Copy link
Member

Bjwebb commented Nov 26, 2019

Here's a text copy of the JSON you shared (yours seems to be an image):

{
  "version": "1.1",
  "extensions": [
    "https://raw.githubusercontent.com/open-contracting-extensions/ocds_coveredBy_extension/master/extension.json"
  ],
  "releases": [
    {
      "tender": {
        "coveredBy": [
          "a",
          "b"
        ]
      }
    }
  ]
}

Bjwebb added a commit that referenced this issue Nov 26, 2019
@ghost ghost mentioned this issue Nov 26, 2019
Bjwebb added a commit that referenced this issue Nov 26, 2019
Bjwebb added a commit that referenced this issue Nov 26, 2019
Bjwebb added a commit that referenced this issue Nov 26, 2019
@Bjwebb
Copy link
Member

Bjwebb commented Nov 26, 2019

This should be fixed now on the live CoVE instance https://standard.open-contracting.org/review/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants