-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
participationFees: Adding id to changed merging behavior #118
Comments
I double checked, and I don't think any other |
@jpmckinney right now, without the id field, if you have more than one item in the participation fees array CoVe report them as duplication (even if they are different) |
Can you report that issue on the CoVE repo? |
Already reported OpenDataServices/cove#1246 for the array of strings case, but now updated with this case too |
I prefer 2. to keep consistency of structure (if not merging strategy) with other arrays. Also, if anyone extended participation fees to include a property which is an array then an |
Oops, we actually already set |
Before 1.1.3, participation fees had no
id
field, which meant the array was merged as a whole. Anid
field was added in 1.1.3 #48, per the schema style guide at the time.However, this had the effect of changing the merging behavior to the identifier merge strategy.
To restore the original behavior, we can either:
id
field"wholeListMerge": true
id
field will be required in future versions, which was added more recently in response to @yolile's comment in participationFees: Addid
field to array of objects #48@duncandewhurst @yolile What is your preference?
The text was updated successfully, but these errors were encountered: