Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Update to GCC 14 #147

Merged
merged 15 commits into from
May 15, 2024
Merged

CI: Update to GCC 14 #147

merged 15 commits into from
May 15, 2024

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented May 9, 2024 •
edited
Loading

fixes (partially) #146

note: ubuntu-24.04 isn't deployed yet, it might take some time

Edit: it is deployed as of now 🎉

@Totto16 Totto16 linked an issue May 9, 2024 that may be closed by this pull request
Update to GCC 14 #146
Closed
6 tasks
@Totto16 Totto16 removed a link to an issue May 9, 2024
Update to GCC 14 #146
Closed
6 tasks
@Totto16 Totto16 mentioned this pull request May 9, 2024
Closed
6 tasks
@Totto16 Totto16 changed the base branch from main to feat/0.6.0 May 11, 2024 13:21
@Totto16 Totto16 mentioned this pull request May 11, 2024
Merged
7 tasks
@Totto16 Totto16 added the maintenance Maintenance related task label May 12, 2024
@Totto16 Totto16 added this to the 0.6.0 milestone May 12, 2024
@Totto16 Totto16 force-pushed the 146-update-to-gcc-14 branch from 64bb13c to e976e5c Compare May 12, 2024 22:32
Totto16 added 5 commits May 13, 2024 00:46
@Totto16
CI: update ubuntu image version from "22.04" to "24.04"
ec948c8
@Totto16
CI: also add ucrt build to
d331e7b
@Totto16
gcc-14:
29eafe6 
- fix build of fmt, since it has a bug, this is solved later, when upgrading fmt (when there is a new release)
@Totto16
gcc 14:
1659c72 
- fix some more compilation errors, use after destroy
@Totto16
gcc-14:
1dc6e75 
- fix build of fmt, use flag in correct spot
@Totto16 Totto16 force-pushed the 146-update-to-gcc-14 branch from fa4f622 to 1dc6e75 Compare May 12, 2024 23:16
@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                                  Stmts    Miss  Cover    Missing
--------------------------------------  -------  ------  -------  --------------------------------------
src/game/mino.cpp                            10      10  0.00%    3-20
src/game/mino.hpp                             1       1  0.00%    19
src/game/mino_stack.cpp                      61      61  0.00%    7-91
src/graphics/point.hpp                        3       3  0.00%    16-23
src/helper/color.cpp                         85      35  58.82%   11-31, 38-53, 61, 75, 145-156, 161-164
src/helper/color.hpp                         83      65  21.69%   41, 45, 48, 73-101, 140-221
src/helper/color_literals.hpp               335      33  90.15%   51, 437, 592, 657-705, 719-722
src/helper/date.cpp                          46      46  0.00%    9-113
src/helper/errors.cpp                        16      16  0.00%    3-29
src/helper/errors.hpp                         0       0  100.00%
src/helper/parse_json.cpp                    23      23  0.00%    6-55
src/helper/random.cpp                        13      13  0.00%    4-24
src/helper/sleep.cpp                         15      15  0.00%    20-71
src/helper/utils.hpp                          2       2  0.00%    61-62
src/thirdparty/hash-library/sha256.cpp      417     417  0.00%    40-604
TOTAL                                      1110     740  33.33%

Results for commit: 49c32e4

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

Totto16 added 3 commits May 15, 2024 00:45
@Totto16
CI: android:
9cd11a7 
- also build mpg123 on x86
@Totto16
CI: android:
ea95dee 
- fix openssl error on armv7
@Totto16
CI: android:
317d9b2 
- fix mpg123 error on x86, the reason it existed was:
the assembly that was used was detecting features of the HOST platform and not the TARGET platform, so SSE code was generated for x86, which has no SSE
@Totto16 Totto16 force-pushed the 146-update-to-gcc-14 branch from 3280b82 to 317d9b2 Compare May 14, 2024 23:37
@Totto16
GCC 14 support:
4c746ae 
- also fix bug for header only fmt
@Totto16 Totto16 force-pushed the 146-update-to-gcc-14 branch from 2875051 to 3a15615 Compare May 14, 2024 23:56
@Totto16
CI: android:
0170816 
-fix mpg123 build  on x86
@Totto16 Totto16 force-pushed the 146-update-to-gcc-14 branch from 3a15615 to 0170816 Compare May 15, 2024 00:18
@Totto16
CI: android:
49c32e4 
-fix mpg123 build  and use correct android cross compile arguments on all archs
@Totto16 Totto16 merged commit afbcb10 into feat/0.6.0 May 15, 2024
17 of 18 checks passed
@Totto16 Totto16 deleted the 146-update-to-gcc-14 branch May 15, 2024 21:01
@Totto16 Totto16 mentioned this pull request May 17, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
maintenance Maintenance related task
Projects
None yet
Milestone
0.5.6
Development

Successfully merging this pull request may close these issues.
1 participant
@Totto16