Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to clang / llvm 18 #144

Merged
merged 3 commits into from
May 11, 2024
Merged

update to clang / llvm 18 #144

merged 3 commits into from
May 11, 2024

Conversation

Totto16
Copy link
Collaborator

@Totto16 Totto16 commented Apr 23, 2024

Fixes (partially) #142

failures are related to error on the macos runner images, that are still not fixed

@Totto16 Totto16 linked an issue Apr 23, 2024 that may be closed by this pull request
2 tasks
Copy link

github-actions bot commented Apr 23, 2024

badge

Code Coverage Summary

Filename                                  Stmts    Miss  Cover    Missing
--------------------------------------  -------  ------  -------  --------------------------------------
src/game/mino.cpp                            10      10  0.00%    3-20
src/game/mino.hpp                             1       1  0.00%    19
src/game/mino_stack.cpp                      61      61  0.00%    7-91
src/graphics/point.hpp                        3       3  0.00%    16-23
src/helper/color.cpp                         85      35  58.82%   11-31, 38-53, 61, 75, 145-156, 161-164
src/helper/color.hpp                         83      65  21.69%   41, 45, 48, 73-101, 140-221
src/helper/color_literals.hpp               335      33  90.15%   51, 437, 592, 657-705, 719-722
src/helper/date.cpp                          46      46  0.00%    9-113
src/helper/errors.cpp                        16      16  0.00%    3-29
src/helper/errors.hpp                         0       0  100.00%
src/helper/parse_json.cpp                    23      23  0.00%    6-55
src/helper/random.cpp                        13      13  0.00%    4-24
src/helper/sleep.cpp                         15      15  0.00%    20-71
src/helper/utils.hpp                          2       2  0.00%    61-62
src/thirdparty/hash-library/sha256.cpp      417     417  0.00%    40-604
TOTAL                                      1110     740  33.33%

Results for commit: c237aa4

Minimum allowed coverage is 0%

♻️ This comment has been updated with latest results

@Totto16
Copy link
Collaborator Author

Totto16 commented Apr 27, 2024

The mac failures where to a bug in homebrew, where the library include path for openssl was wrong, see Homebrew/homebrew-core#169728 and Homebrew/homebrew-core#169728

even if this was fixed upstream, openssl is preinstalled on the runner images, so we need to wait for actions/runner-images#9755

which releases the fix on ~ 7. May

@Totto16 Totto16 mentioned this pull request May 2, 2024
@Totto16 Totto16 added the maintenance Maintenance related task label May 2, 2024
@Totto16 Totto16 force-pushed the 142-update-to-llvm-18 branch from 20866b9 to c237aa4 Compare May 9, 2024 19:26
@Totto16 Totto16 mentioned this pull request May 10, 2024
2 tasks
@Totto16 Totto16 removed a link to an issue May 10, 2024
2 tasks
@Totto16 Totto16 changed the base branch from main to feat/0.6.0 May 11, 2024 12:47
@Totto16 Totto16 merged commit fb1ecf4 into feat/0.6.0 May 11, 2024
29 of 32 checks passed
@Totto16 Totto16 deleted the 142-update-to-llvm-18 branch May 11, 2024 12:48
@Totto16 Totto16 added this to the 0.6.0 milestone May 12, 2024
This was referenced May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant