Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[frontend] Fix bulk actions on sparse selection (#2328) #2323

Merged
merged 6 commits into from
Jan 30, 2025

Conversation

antoinemzs
Copy link
Contributor

@antoinemzs antoinemzs commented Jan 30, 2025

Proposed changes

  • Fix bulk actions on sparse selection

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality
  • For bug fix -> I implemented a test that covers the bug

@antoinemzs antoinemzs changed the base branch from master to release/current January 30, 2025 08:58
Signed-off-by: Antoine MAZEAS <[email protected]>
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.55%. Comparing base (29e28d5) to head (47b5f07).
Report is 3 commits behind head on release/current.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #2323      +/-   ##
=====================================================
+ Coverage              36.28%   37.55%   +1.26%     
- Complexity              1656     1801     +145     
=====================================================
  Files                    589      592       +3     
  Lines                  18066    18832     +766     
  Branches                1176     1285     +109     
=====================================================
+ Hits                    6555     7072     +517     
- Misses                 11185    11394     +209     
- Partials                 326      366      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@antoinemzs antoinemzs linked an issue Jan 30, 2025 that may be closed by this pull request
Signed-off-by: Antoine MAZEAS <[email protected]>
Signed-off-by: Antoine MAZEAS <[email protected]>
@antoinemzs antoinemzs changed the title [frontend] select all checkbox to allow exporting full page of injects (#2292) [frontend] Fix bulk actions on sparse selection (#2328) Jan 30, 2025
@antoinemzs antoinemzs marked this pull request as ready for review January 30, 2025 14:19
Comment on lines +20 to +22
// we don't know the type of every value in an object type passed here
// nor is it relevant.
/* eslint-disable @typescript-eslint/no-explicit-any */
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to note

@antoinemzs antoinemzs merged commit 8b9c7e2 into release/current Jan 30, 2025
6 checks passed
@antoinemzs antoinemzs deleted the fix/select_all_in_list branch January 30, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bottom bar bulk actions in Injects list view do not work reliably with sparse selection
2 participants