Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting all injects and exporting (XLS) does not work #2292

Closed
EllynBsc opened this issue Jan 24, 2025 · 8 comments
Closed

Selecting all injects and exporting (XLS) does not work #2292

EllynBsc opened this issue Jan 24, 2025 · 8 comments
Assignees
Labels
bug use for describing something not working as expected wontfix This will not be worked on

Comments

@EllynBsc
Copy link
Member

Description

The following use case does not work: As a user, I want to export all my injects.

Environment

1.11.4

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. I select all the injects
  2. I click on the three dots to export my selection in XLS

Expected Output

I get an XLS file with the injects inside

Actual Output

I get an empty XLS file

Screenshots (optional)

Image

@EllynBsc EllynBsc added bug use for describing something not working as expected regression Label to identify the bug as a regression of previously working feature labels Jan 24, 2025
@EllynBsc EllynBsc added this to the Bugs backlog milestone Jan 24, 2025
@RomuDeuxfois
Copy link
Member

Should be killed by #2291 right ?

@antoinemzs
Copy link
Contributor

There's a discrepancy in how the "select all" checkbox is used on the frontend,

On one hand, it selects all elements on all pages for backend-side jobs such as bulk updating a property.

On the other it is expected to "select all" for a frontend-side job (XLS export), but not all entities may be loaded on a single page, hence the XLS export is currently limited to at most a page worth of entities. We could contort to backfill all pages into the export function with a bit of extra effort.

Should be killed by #2291 right ?

It propably would, although the key limitor here is working from the frontend to do this export. We may want to move all import/export functionality to the backend eventually, be it XLS or JSON.

@antoinemzs
Copy link
Contributor

A stop-gap fix would perhaps look like #2323; it's still inconsistent with the bottom contextual toolbar that comes up when selecting items in the list (1 page of elements for the export button, vs all elements in all pages for the bottom bar buttons).

@antoinemzs antoinemzs self-assigned this Jan 30, 2025
@antoinemzs
Copy link
Contributor

Selecting sparse records (not select all) and using the bottom tool bar does not update items on all pages, only the currently displayed page.

@antoinemzs antoinemzs linked a pull request Jan 30, 2025 that will close this issue
6 tasks
@antoinemzs
Copy link
Contributor

antoinemzs commented Jan 30, 2025

There's currently no way of making the export function work sensibly without preloading the entire inject collection. It's quite ugly, especially since otherwise we are able to function with paginated subsets.

After speaking with @guillaumejparis and @Dimfacion we would propose disabling the current frontend-based XLS functionality in favour of the upcoming #2291 and prioritise its release.

I would create a new issue for the other bugs I found and point #2323 to it.

cc @EllynBsc @jborozco @RomuDeuxfois

@RomuDeuxfois
Copy link
Member

We will have the same technical issues with the #2291 right ?

@antoinemzs
Copy link
Contributor

No, I expect we will favour a server-side export, which will be able to reconcile injects based on the front-side selection, much like the bulk actions do now.

@jborozco
Copy link

Closing this issue, as discussed, the feature will be depreciated with this coming task #2291

No need to remove the export buttons it will be hadled as well in the coming feature.

@jborozco jborozco closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
@jborozco jborozco added wontfix This will not be worked on and removed regression Label to identify the bug as a regression of previously working feature labels Jan 30, 2025
@SamuelHassine SamuelHassine removed this from the Bugs backlog milestone Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

5 participants