-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Selecting all injects and exporting (XLS) does not work #2292
Comments
Should be killed by #2291 right ? |
There's a discrepancy in how the "select all" checkbox is used on the frontend, On one hand, it selects all elements on all pages for backend-side jobs such as bulk updating a property. On the other it is expected to "select all" for a frontend-side job (XLS export), but not all entities may be loaded on a single page, hence the XLS export is currently limited to at most a page worth of entities. We could contort to backfill all pages into the export function with a bit of extra effort.
It propably would, although the key limitor here is working from the frontend to do this export. We may want to move all import/export functionality to the backend eventually, be it XLS or JSON. |
A stop-gap fix would perhaps look like #2323; it's still inconsistent with the bottom contextual toolbar that comes up when selecting items in the list (1 page of elements for the export button, vs all elements in all pages for the bottom bar buttons). |
Selecting sparse records (not select all) and using the bottom tool bar does not update items on all pages, only the currently displayed page. |
There's currently no way of making the export function work sensibly without preloading the entire inject collection. It's quite ugly, especially since otherwise we are able to function with paginated subsets. After speaking with @guillaumejparis and @Dimfacion we would propose disabling the current frontend-based XLS functionality in favour of the upcoming #2291 and prioritise its release. I would create a new issue for the other bugs I found and point #2323 to it. |
We will have the same technical issues with the #2291 right ? |
No, I expect we will favour a server-side export, which will be able to reconcile injects based on the front-side selection, much like the bulk actions do now. |
Closing this issue, as discussed, the feature will be depreciated with this coming task #2291 No need to remove the export buttons it will be hadled as well in the coming feature. |
Description
The following use case does not work: As a user, I want to export all my injects.
Environment
1.11.4
Reproducible Steps
Steps to create the smallest reproducible scenario:
Expected Output
I get an XLS file with the injects inside
Actual Output
I get an empty XLS file
Screenshots (optional)
The text was updated successfully, but these errors were encountered: