-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[backend/frontend] Ability to see 100 simulations in the overview of a scenario in 0.5 seconds #1995
Conversation
7259a5d
to
82cbbe4
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/1.10.0 #1995 +/- ##
====================================================
+ Coverage 33.91% 34.95% +1.04%
- Complexity 1306 1390 +84
====================================================
Files 524 531 +7
Lines 15823 15947 +124
Branches 998 1002 +4
====================================================
+ Hits 5366 5574 +208
+ Misses 10194 10093 -101
- Partials 263 280 +17 ☔ View full report in Codecov by Sentry. |
d99a9c7
to
8752c6c
Compare
7cf695e
to
5fd5f84
Compare
openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java
Outdated
Show resolved
Hide resolved
openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java
Outdated
Show resolved
Hide resolved
5fd5f84
to
2466f30
Compare
openbas-api/src/test/java/io/openbas/rest/scenario/service/ScenarioStatisticServiceTest.java
Outdated
Show resolved
Hide resolved
openbas-api/src/test/java/io/openbas/utils/ResultUtilsTest.java
Outdated
Show resolved
Hide resolved
2466f30
to
c111940
Compare
- add intermediate record to sort as stream - sort raw exercises with stream - fix percentage type - add tracing in scenario statistics route - add tests for global scores route and statistics service - truncate global score success percentage to have only one decimal - simplify scenario statistics obtention
- update global scores success percentage type - revert chart colors and use xs loader for async global score - display custom tooltip on simulations results - change wording in chart title - fix display of loading global score icons - fix loading display of global scores - display by default scenarios by update date and desc
c111940
to
245766b
Compare
openbas-front/src/admin/components/scenarios/scenario/Scenario.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ok!
Great job!
Proposed changes
Related issues
Checklist
Further comments
Loading times
Data: 100 simulations with 50 injects each
Branch: issue/1911
http://localhost:3001/api/scenarios/2de41219-c7c6-48b3-8edf-e41781efd105/exercises/search
34.11 ms (8.5 times faster)
http://localhost:3001/api/scenarios/2de41219-c7c6-48b3-8edf-e41781efd105/statistics (new)
76.81ms (4.4 times faster)
Branch: release/1.10.0
http://localhost:3001/api/scenarios/2de41219-c7c6-48b3-8edf-e41781efd105/exercises/search
291.62 ms
http://localhost:3001/api/scenarios/2de41219-c7c6-48b3-8edf-e41781efd105/exercises
338.27 ms