[backend] feedbacks

OpenBAS-Platform · Dec 11, 2024 · c111940 · c111940
1 parent 9d0cd0c
commit c111940
Showing 1 changed file with 2 additions and 7 deletions.
diff --git a/openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java b/openbas-api/src/main/java/io/openbas/rest/exercise/service/ExerciseService.java
@@ -473,8 +473,7 @@ private void setComputedAttributes(List<ExerciseSimple> originalExercises) {
     }
 
     Set<String> exerciseIds = getExerciseIds(exercises);
-    MappingsByExerciseIds mappingsByExerciseIds =
-        getResultsByExerciseIds(getExerciseIds(exercises));
+    MappingsByExerciseIds mappingsByExerciseIds = getResultsByExerciseIds(exerciseIds);
 
     Map<String, List<RawInjectExpectation>> expectationsByExerciseIds =
         getExpectationsByExerciseId(exerciseIds);
@@ -496,7 +495,7 @@ private void setComputedAttributesWithEmptyGlobalScore(List<ExerciseSimple> orig
         getResultsByExerciseIds(getExerciseIds(exercises));
 
     for (ExerciseSimple exercise : exercises) {
-      setEmptyGlobalScore(exercise);
+      exercise.setExpectationResultByTypes(new ArrayList<>());
 
       setTargets(exercise, mappingsByExerciseIds);
     }
@@ -558,10 +557,6 @@ private static void setGlobalScore(
             expectationsByExerciseIds.getOrDefault(exercise.getId(), emptyList())));
   }
 
-  private static void setEmptyGlobalScore(ExerciseSimple exercise) {
-    exercise.setExpectationResultByTypes(new ArrayList<>());
-  }
-
   private void setTargets(ExerciseSimple exercise, MappingsByExerciseIds mappingsByExerciseIds) {
     List<TargetSimple> allTargets =
         Stream.of(