[scala][client] invoker package enhancement #9381

sandeepjindal · 2021-05-01T14:47:18Z

Here are the details in the issue: #9378

Steps to verify the change run these commands:

./mvnw clean package
./bin/generate-samples.sh bin/configs/scala-legacy.yaml

you should see the new invoker pacakge like this:

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
@mention the@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

chameleon82

Thanks for the PR @sandeepjindal.
Please ensure for most of scala clients invokerPackage by default is mainPackage + ".core" this PR will not override default behavior.
Please run the script ./bin/generate-samples.sh to regenerate all scala clients

sandeepjindal · 2021-05-01T16:11:44Z

Please ensure for most of scala clients invokerPackage by default is mainPackage + ".core" this PR will not override default behavior.

Only below marked language framework is using invokerPackage should i check in these only:

sandeepjindal · 2021-05-05T13:39:14Z

@chameleon82 Thanks for the help i have pushed the fix, please help review and approve.

chameleon82 · 2021-05-06T01:42:57Z

bin/configs/scala-legacy.yaml

+additionalProperties:
+  apiPackage: org.openapitools.example.api
+  invokerPackage: org.openapitools.example.invoker
+  artifactId: scala-legacy-petstore


@sandeepjindal Please run and commit those files

./bin/generate-samples.sh bin/configs/scala-legacy.yaml

Done please check

sandeepjindal · 2021-05-09T08:17:25Z

Maintainers:
@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)
Please help merge.

wing328 · 2021-05-12T14:28:45Z

I ran sbt test on samples/client/petstore/scala-httpclient-deprecated but got the following errors:

[info] Non-compiled module 'compiler-bridge_2.11' for Scala 2.11.12. Compiling...
[info]   Compilation completed in 8.364s.
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:40:8: ScalaJsonUtil is already defined as object ScalaJsonUtil
[error] object ScalaJsonUtil {
[error]        ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:54:7: ApiInvoker is already defined as class ApiInvoker
[error] class ApiInvoker(val mapper: ObjectMapper = ScalaJsonUtil.getJsonMapper,
[error]       ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:237:7: ApiException is already defined as class ApiException
[error] class ApiException(val code: Int, msg: String) extends RuntimeException(msg)
[error]       ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/AsyncClient.scala:9:7: AsyncClient is already defined as class AsyncClient
[error] class AsyncClient(config: SwaggerConfig) extends Closeable {
[error]       ^
[error] four errors found
[error] (Compile / compileIncremental) Compilation failed
[error] Total time: 21 s, completed 12 May 2021, 10:27:43 pm

Does it work for you in your machine?

sandeepjindal · 2021-05-12T17:44:06Z

I ran sbt test on samples/client/petstore/scala-httpclient-deprecated but got the following errors:

[info] Non-compiled module 'compiler-bridge_2.11' for Scala 2.11.12. Compiling...
[info]   Compilation completed in 8.364s.
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:40:8: ScalaJsonUtil is already defined as object ScalaJsonUtil
[error] object ScalaJsonUtil {
[error]        ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:54:7: ApiInvoker is already defined as class ApiInvoker
[error] class ApiInvoker(val mapper: ObjectMapper = ScalaJsonUtil.getJsonMapper,
[error]       ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/ApiInvoker.scala:237:7: ApiException is already defined as class ApiException
[error] class ApiException(val code: Int, msg: String) extends RuntimeException(msg)
[error]       ^
[error] /Users/williamcheng/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/src/main/scala/org/openapitools/example/invoker/AsyncClient.scala:9:7: AsyncClient is already defined as class AsyncClient
[error] class AsyncClient(config: SwaggerConfig) extends Closeable {
[error]       ^
[error] four errors found
[error] (Compile / compileIncremental) Compilation failed
[error] Total time: 21 s, completed 12 May 2021, 10:27:43 pm

Does it work for you in your machine?

Thanks for notifying, removed duplicated files.

remove unwanted set the invoker fixed the ordering of supported files added sample generated files regenerated samples added docs

sandeepjindal · 2021-05-15T09:36:36Z

Maintainers:
@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

please help review.
As checked the failure is not related with branch changes

sandeepjindal · 2021-05-25T03:09:52Z

Maintainers:
@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)

please help review.
As checked the failure is not related with branch changes

May i please followup on this

chameleon82 · 2021-05-25T03:49:52Z

@wing328 could you help to check circleci build? seems it is not pr changes related fail

sandeepjindal · 2021-06-17T10:09:38Z

@wing328 can i please followup on this

wing328 · 2021-06-18T07:13:34Z

CircleCI failure already fixed in the master.

wing328 · 2021-06-18T07:53:19Z

Tested samples/client/petstore/scala-httpclient-deprecated again and no longer seeing the same issue:

[warn] There may be incompatibilities among your library dependencies; run 'evicted' to see detailed eviction warnings.
[info] Compiling 11 Scala sources to /home/wing328/Code/openapi-generator/samples/client/petstore/scala-httpclient-deprecated/target/scala-2.11/classes ...
[info] Non-compiled module 'compiler-bridge_2.11' for Scala 2.11.12. Compiling...
[info]   Compilation completed in 32.052s.
[info] Done compiling.
WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by com.google.protobuf.UnsafeUtil (file:/home/wing328/.sbt/boot/scala-2.12.7/org.scala-sbt/sbt/1.2.8/protobuf-java-3.3.1.jar) to field java.nio.Buffer.address
WARNING: Please consider reporting this to the maintainers of com.google.protobuf.UnsafeUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release
[info] Run completed in 143 milliseconds.
[info] Total number of tests run: 0
[info] Suites: completed 0, aborted 0
[info] Tests: succeeded 0, failed 0, canceled 0, ignored 0, pending 0
[info] No tests were executed.
[success] Total time: 194 s, completed Jun 18, 2021, 3:49:24 PM

sandeepjindal · 2021-06-18T08:15:35Z

Thanks appreciated @wing328 @chameleon82

sandeepjindal mentioned this pull request May 1, 2021

[REQ] Setting invoker package name for AbstractScalaCodegen #9378

Closed

sandeepjindal changed the title ~~updated invoker~~ [scala][client] invoker package enhancement May 1, 2021

chameleon82 reviewed May 1, 2021

View reviewed changes

chameleon82 reviewed May 6, 2021

View reviewed changes

chameleon82 approved these changes May 6, 2021

View reviewed changes

updated invoker

a3f4962

remove unwanted set the invoker fixed the ordering of supported files added sample generated files regenerated samples added docs

sandeepjindal force-pushed the invoker-packer-enhancement branch from 9223ba5 to a3f4962 Compare May 14, 2021 03:16

sample files

7914236

wing328 merged commit c7038d1 into OpenAPITools:master Jun 18, 2021

wing328 added Client: Scala Enhancement: General labels Jun 18, 2021

wing328 added this to the 5.2.0 milestone Jun 18, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[scala][client] invoker package enhancement #9381

[scala][client] invoker package enhancement #9381

sandeepjindal commented May 1, 2021 •

edited

Loading

chameleon82 left a comment

sandeepjindal commented May 1, 2021 •

edited

Loading

sandeepjindal commented May 5, 2021

chameleon82 May 6, 2021

sandeepjindal May 6, 2021

sandeepjindal commented May 9, 2021

wing328 commented May 12, 2021

sandeepjindal commented May 12, 2021

sandeepjindal commented May 15, 2021

sandeepjindal commented May 25, 2021

chameleon82 commented May 25, 2021

sandeepjindal commented Jun 17, 2021

wing328 commented Jun 18, 2021

wing328 commented Jun 18, 2021

sandeepjindal commented Jun 18, 2021

[scala][client] invoker package enhancement #9381

[scala][client] invoker package enhancement #9381

Conversation

sandeepjindal commented May 1, 2021 • edited Loading

PR checklist

chameleon82 left a comment

Choose a reason for hiding this comment

sandeepjindal commented May 1, 2021 • edited Loading

sandeepjindal commented May 5, 2021

chameleon82 May 6, 2021

Choose a reason for hiding this comment

sandeepjindal May 6, 2021

Choose a reason for hiding this comment

sandeepjindal commented May 9, 2021

wing328 commented May 12, 2021

sandeepjindal commented May 12, 2021

sandeepjindal commented May 15, 2021

sandeepjindal commented May 25, 2021

chameleon82 commented May 25, 2021

sandeepjindal commented Jun 17, 2021

wing328 commented Jun 18, 2021

wing328 commented Jun 18, 2021

sandeepjindal commented Jun 18, 2021

sandeepjindal commented May 1, 2021 •

edited

Loading

sandeepjindal commented May 1, 2021 •

edited

Loading